Different clang-tidy errors locally

[johnwason]

I am getting a lot more clang-tidy errors when I run it locally. Is the docker running an older version of clang-tidy or cmake boilerplate?

[Levi-Armstrong]

Are you on 22.04 or 20.04?

[johnwason]

I think you will need to explicitly disable the new tests that are not included in clang-tidy-10, unless you want to go through the code and update to clang-tidy-14.

[johnwason]

The build server for ROS 2 Humble appears to run clang-tidy-14 on code submitted.

[Levi-Armstrong]

I will update to clang-tidy-14

[Levi-Armstrong]

It looks like on 20.04 by default you can only install clang-tidy-12 so I will update it to this for now.

[Levi-Armstrong]

@johnwason I tried upgrading to 12 but I was getting weird false positives so I decide to go ahead and upgraded to 14. The previous false positive went away but I am getting new false positives, the main one is that header only files report unused function argument variables when they are clearly used. Have you experienced this?

[johnwason]

@Levi-Armstrong I haven't had a chance to look at this yet, but I'll get to it this week.

[Levi-Armstrong]

I created this issue on llvm which is currently the largest hurdle for using 14, but still getting odd false positive.