Replies: 1 comment 1 reply
-
I don't see any issues dropping the const. @mpowelson Do you have any issue with dropping the const? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
IterativeSplineParameterization::compute(const std::vector<std::reference_wrapper<Instruction>>& trajectory, ...)
usesconst&
for thetrajectory
parameter, even though this is an in/out parameters. While this may be technically correct, it is confusing sinceconst&
parameters are typically input only, and SWIG makes that assumption in a lot of places. It would be better to drop theconst
and leave it as a reference.Beta Was this translation helpful? Give feedback.
All reactions