Skip to content

Commit dc48a1a

Browse files
mpowelsonLevi-Armstrong
mpowelson
authored and
Levi-Armstrong
committed
Split clang-tidy args across multiple lines to make it easier to read
1 parent 9f85b1d commit dc48a1a

File tree

1 file changed

+102
-2
lines changed

1 file changed

+102
-2
lines changed

‎tesseract/tesseract_common/cmake/tesseract_macros.cmake

Lines changed: 102 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,41 @@ macro(tesseract_variables)
5656
set(TESSERACT_COMPILE_OPTIONS_PUBLIC "")
5757
set(TESSERACT_COMPILE_OPTIONS_PRIVATE "")
5858
if (NOT TESSERACT_ENABLE_TESTING AND NOT TESSERACT_ENABLE_TESTING_ALL)
59-
set(TESSERACT_CLANG_TIDY_ARGS "-header-filter=.*" "-line-filter=[{'name':'EnvironmentMonitorDynamicReconfigureConfig.h','lines':[[9999999,9999999]]}, {'name':'.h'}, {'name':'.hpp'}]" "-checks=-*,clang-analyzer-*,bugprone-*,cppcoreguidelines-avoid-goto,cppcoreguidelines-c-copy-assignment-signature,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-no-malloc,cppcoreguidelines-slicing,cppcoreguidelines-special-member-functions,misc-*,-misc-non-private-member-variables-in-classes,modernize-*,-modernize-use-trailing-return-type,-modernize-use-nodiscard,performance-*,readability-avoid-const-params-in-decls,readability-container-size-empty,readability-delete-null-pointer,readability-deleted-default,readability-else-after-return,readability-function-size,readability-identifier-naming,readability-inconsistent-declaration-parameter-name,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-*,readability-simplify-*,readability-static-*,readability-string-compare,readability-uniqueptr-delete-release,readability-rary-objects")
59+
set(TESSERACT_CLANG_TIDY_ARGS "-header-filter=.*"
60+
"-line-filter=[{'name':'EnvironmentMonitorDynamicReconfigureConfig.h','lines':[[9999999,9999999]]}, {'name':'.h'}, {'name':'.hpp'}]"
61+
"-checks=-*, \
62+
clang-analyzer-*, \
63+
bugprone-*, \
64+
cppcoreguidelines-avoid-goto, \
65+
cppcoreguidelines-c-copy-assignment-signature, \
66+
cppcoreguidelines-interfaces-global-init, \
67+
cppcoreguidelines-narrowing-conversions, \
68+
cppcoreguidelines-no-malloc, \
69+
cppcoreguidelines-slicing, \
70+
cppcoreguidelines-special-member-functions, \
71+
misc-*, \
72+
-misc-non-private-member-variables-in-classes, \
73+
modernize-*, \
74+
-modernize-use-trailing-return-type, \
75+
-modernize-use-nodiscard, \
76+
performance-*, \
77+
readability-avoid-const-params-in-decls, \
78+
readability-container-size-empty, \
79+
readability-delete-null-pointer, \
80+
readability-deleted-default, \
81+
readability-else-after-return, \
82+
readability-function-size, \
83+
readability-identifier-naming, \
84+
readability-inconsistent-declaration-parameter-name, \
85+
readability-misleading-indentation, \
86+
readability-misplaced-array-index, \
87+
readability-non-const-parameter, \
88+
readability-redundant-*, \
89+
readability-simplify-*, \
90+
readability-static-*, \
91+
readability-string-compare, \
92+
readability-uniqueptr-delete-release, \
93+
readability-rary-objects")
6094
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
6195
set(TESSERACT_COMPILE_OPTIONS_PRIVATE -Wall -Wextra -Wconversion -Wsign-conversion -Wno-sign-compare -Wnon-virtual-dtor)
6296
set(TESSERACT_COMPILE_OPTIONS_PUBLIC -mno-avx)
@@ -70,7 +104,73 @@ macro(tesseract_variables)
70104
message(WARNING "${CMAKE_CXX_COMPILER_ID} Unsupported compiler detected.")
71105
endif()
72106
else()
73-
set(TESSERACT_CLANG_TIDY_ARGS "-header-filter=.*" "-line-filter=[{'name':'EnvironmentMonitorDynamicReconfigureConfig.h','lines':[[9999999,9999999]]}, {'name':'.h'}, {'name':'.hpp'}]" "-checks=-*,clang-analyzer-*,bugprone-*,cppcoreguidelines-avoid-goto,cppcoreguidelines-c-copy-assignment-signature,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-no-malloc,cppcoreguidelines-slicing,cppcoreguidelines-special-member-functions,misc-*,-misc-non-private-member-variables-in-classes,modernize-*,-modernize-use-trailing-return-type,-modernize-use-nodiscard,performance-*,readability-avoid-const-params-in-decls,readability-container-size-empty,readability-delete-null-pointer,readability-deleted-default,readability-else-after-return,readability-function-size,readability-identifier-naming,readability-inconsistent-declaration-parameter-name,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-*,readability-simplify-*,readability-static-*,readability-string-compare,readability-uniqueptr-delete-release,readability-rary-objects" "-warnings-as-errors=-*,clang-analyzer-*,bugprone-*,cppcoreguidelines-avoid-goto,cppcoreguidelines-c-copy-assignment-signature,cppcoreguidelines-interfaces-global-init,cppcoreguidelines-narrowing-conversions,cppcoreguidelines-no-malloc,cppcoreguidelines-slicing,cppcoreguidelines-special-member-functions,misc-*,-misc-non-private-member-variables-in-classes,modernize-*,-modernize-use-trailing-return-type,-modernize-use-nodiscard,performance-*,readability-avoid-const-params-in-decls,readability-container-size-empty,readability-delete-null-pointer,readability-deleted-default,readability-else-after-return,readability-function-size,readability-identifier-naming,readability-inconsistent-declaration-parameter-name,readability-misleading-indentation,readability-misplaced-array-index,readability-non-const-parameter,readability-redundant-*,readability-simplify-*,readability-static-*,readability-string-compare,readability-uniqueptr-delete-release,readability-rary-objects")
107+
set(TESSERACT_CLANG_TIDY_ARGS "-header-filter=.*"
108+
"-line-filter=[{'name':'EnvironmentMonitorDynamicReconfigureConfig.h','lines':[[9999999,9999999]]}, {'name':'.h'}, {'name':'.hpp'}]"
109+
"-checks=-*, \
110+
clang-analyzer-*, \
111+
bugprone-*, \
112+
cppcoreguidelines-avoid-goto, \
113+
cppcoreguidelines-c-copy-assignment-signature, \
114+
cppcoreguidelines-interfaces-global-init, \
115+
cppcoreguidelines-narrowing-conversions, \
116+
cppcoreguidelines-no-malloc, \
117+
cppcoreguidelines-slicing, \
118+
cppcoreguidelines-special-member-functions, \
119+
misc-*, \
120+
-misc-non-private-member-variables-in-classes, \
121+
modernize-*, \
122+
-modernize-use-trailing-return-type, \
123+
-modernize-use-nodiscard, \
124+
performance-*, \
125+
readability-avoid-const-params-in-decls, \
126+
readability-container-size-empty, \
127+
readability-delete-null-pointer, \
128+
readability-deleted-default, \
129+
readability-else-after-return, \
130+
readability-function-size, \
131+
readability-identifier-naming, \
132+
readability-inconsistent-declaration-parameter-name, \
133+
readability-misleading-indentation, \
134+
readability-misplaced-array-index, \
135+
readability-non-const-parameter, \
136+
readability-redundant-*, \
137+
readability-simplify-*, \
138+
readability-static-*, \
139+
readability-string-compare, \
140+
readability-uniqueptr-delete-release, \
141+
readability-rary-objects" "-warnings-as-errors=-*, \
142+
clang-analyzer-*, \
143+
bugprone-*, \
144+
cppcoreguidelines-avoid-goto, \
145+
cppcoreguidelines-c-copy-assignment-signature, \
146+
cppcoreguidelines-interfaces-global-init, \
147+
cppcoreguidelines-narrowing-conversions, \
148+
cppcoreguidelines-no-malloc, \
149+
cppcoreguidelines-slicing, \
150+
cppcoreguidelines-special-member-functions, \
151+
misc-*, \
152+
-misc-non-private-member-variables-in-classes, \
153+
modernize-*, \
154+
-modernize-use-trailing-return-type, \
155+
-modernize-use-nodiscard, \
156+
performance-*, \
157+
readability-avoid-const-params-in-decls, \
158+
readability-container-size-empty, \
159+
readability-delete-null-pointer, \
160+
readability-deleted-default, \
161+
readability-else-after-return, \
162+
readability-function-size, \
163+
readability-identifier-naming, \
164+
readability-inconsistent-declaration-parameter-name, \
165+
readability-misleading-indentation, \
166+
readability-misplaced-array-index, \
167+
readability-non-const-parameter, \
168+
readability-redundant-*, \
169+
readability-simplify-*, \
170+
readability-static-*, \
171+
readability-string-compare, \
172+
readability-uniqueptr-delete-release, \
173+
readability-rary-objects")
74174
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
75175
set(TESSERACT_COMPILE_OPTIONS_PRIVATE -Werror=all -Werror=extra -Werror=conversion -Werror=sign-conversion -Wno-sign-compare -Werror=non-virtual-dtor)
76176
set(TESSERACT_COMPILE_OPTIONS_PUBLIC -mno-avx)

0 commit comments

Comments
 (0)