Skip to content

Commit 656506d

Browse files
Fix to handle console_bridge target renaming in noetic
1 parent 43af6eb commit 656506d

File tree

33 files changed

+178
-43
lines changed

33 files changed

+178
-43
lines changed

.github/workflows/windows_noetic_build.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,14 @@ jobs:
2929
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 -host_arch=amd64
3030
call "C:\opt\ros\%ROS_DISTRO%\x64\setup.bat"
3131
32-
choco install console_bridge -y --no-progress
33-
choco install clapack -y --no-progress
34-
choco install openblas -y --no-progress
35-
36-
set PATH=D:\a\tesseract\tesseract\install_isolated\bin;C:\opt\rosdeps\x64\bin;C:\opt\rosdeps\x64\lib;%PATH%
37-
set LD_LIBRARY_PATH=D:\a\tesseract\tesseract\install_isolated\lib;C:\opt\rosdeps\x64\lib;%LD_LIBRARY_PATH%
38-
set CMAKE_PREFIX_PATH=D:\a\tesseract\tesseract\install_isolated\CMake;C:\opt\rosdeps\x64;%CMAKE_PREFIX_PATH%
39-
set PKG_CONFIG_PATH=D:\a\tesseract\tesseract\install_isolated\lib\pkgconfig;C:\opt\rosdeps\x64\lib\pkgconfig;%PKG_CONFIG_PATH%
40-
4132
set
4233
34+
rosdep update
35+
4336
vcs import --input "${{ github.workspace }}/src/tesseract/dependencies.rosinstall" src/
4437
38+
rosdep install -q --from-paths . --ignore-src -y
39+
4540
catkin_make_isolated --install --force-cmake --only-pkg-with-deps tesseract tesseract_collision tesseract_common tesseract_environment tesseract_geometry tesseract_kinematics tesseract_scene_graph tesseract_support tesseract_urdf tesseract_visualization --cmake-args -DCMAKE_BUILD_TYPE=Release
4641
call "D:\a\tesseract\tesseract\install_isolated\setup.bat"
4742
catkin_make_isolated --install --force-cmake --pkg tesseract tesseract_collision tesseract_common tesseract_environment tesseract_geometry tesseract_kinematics tesseract_scene_graph tesseract_urdf tesseract_visualization --cmake-args -DCMAKE_BUILD_TYPE=Release -DTESSERACT_ENABLE_TESTING=ON

tesseract/tesseract/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ find_package(tesseract_urdf REQUIRED)
1717
find_package(tesseract_command_language REQUIRED)
1818
find_package(cmake_common_scripts REQUIRED)
1919

20+
if(NOT TARGET console_bridge::console_bridge)
21+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
22+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
23+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
24+
endif()
25+
2026
set(COVERAGE_EXCLUDE /usr/* /opt/* ${CMAKE_CURRENT_LIST_DIR}/test/* /*/gtest/*)
2127

2228
add_code_coverage_all_targets(EXCLUDE ${COVERAGE_EXCLUDE})
@@ -35,7 +41,7 @@ target_link_libraries(${PROJECT_NAME} PUBLIC
3541
tesseract::tesseract_kinematics_kdl
3642
tesseract::tesseract_kinematics_opw
3743
tesseract::tesseract_command_language
38-
console_bridge)
44+
console_bridge::console_bridge)
3945
target_compile_options(${PROJECT_NAME} PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE})
4046
target_compile_options(${PROJECT_NAME} PUBLIC ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
4147
target_compile_definitions(${PROJECT_NAME} PUBLIC ${TESSERACT_COMPILE_DEFINITIONS})

tesseract/tesseract/cmake/tesseract-config.cmake.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,10 @@ find_dependency(tesseract_urdf)
2121
find_dependency(console_bridge)
2222
find_dependency(tesseract_command_language)
2323

24+
if(NOT TARGET console_bridge::console_bridge)
25+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
26+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
27+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
28+
endif()
29+
2430
include("${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@-targets.cmake")

tesseract/tesseract_collision/CMakeLists.txt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ link_directories(BEFORE ${FCL_LIBRARY_DIRS})
2222
include_directories(BEFORE "${BULLET_ROOT_DIR}/${BULLET_INCLUDE_DIRS}")
2323
link_directories(BEFORE "${BULLET_ROOT_DIR}/${BULLET_LIBRARY_DIRS}")
2424

25+
if(NOT TARGET console_bridge::console_bridge)
26+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
27+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
28+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
29+
endif()
2530

2631
# These targets are necessary for 16.04 builds. Remove when Kinetic support is dropped
2732
if(NOT TARGET octomap)
@@ -71,7 +76,7 @@ add_library(${PROJECT_NAME}_bullet
7176
src/bullet/tesseract_convex_convex_algorithm.cpp
7277
src/bullet/tesseract_gjk_pair_detector.cpp
7378
)
74-
target_link_libraries(${PROJECT_NAME}_bullet PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_geometry console_bridge octomap octomath)
79+
target_link_libraries(${PROJECT_NAME}_bullet PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_geometry console_bridge::console_bridge octomap octomath)
7580
target_link_libraries(${PROJECT_NAME}_bullet PUBLIC ${BULLET_LIBRARIES})
7681
target_compile_options(${PROJECT_NAME}_bullet PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE})
7782
target_compile_options(${PROJECT_NAME}_bullet PUBLIC ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
@@ -92,7 +97,7 @@ add_library(${PROJECT_NAME}_fcl
9297
src/fcl/fcl_discrete_managers.cpp
9398
src/fcl/fcl_utils.cpp
9499
src/fcl/fcl_collision_object_wrapper.cpp)
95-
target_link_libraries(${PROJECT_NAME}_fcl PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_geometry fcl ${BULLET_LIBRARIES} console_bridge octomap octomath)
100+
target_link_libraries(${PROJECT_NAME}_fcl PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_geometry fcl ${BULLET_LIBRARIES} console_bridge::console_bridge octomap octomath)
96101
target_compile_options(${PROJECT_NAME}_fcl PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE})
97102
target_compile_options(${PROJECT_NAME}_fcl PUBLIC ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
98103
target_compile_definitions(${PROJECT_NAME}_fcl PUBLIC ${TESSERACT_COMPILE_DEFINITIONS} ${BULLET_DEFINITIONS})
@@ -139,7 +144,7 @@ set(PACKAGE_LIBRARIES ${PROJECT_NAME}_core ${PROJECT_NAME}_bullet ${PROJECT_NAME
139144
if (NOT MSVC)
140145
# Create target for creating convex hull's from meshes
141146
add_executable(create_convex_hull src/create_convex_hull.cpp)
142-
target_link_libraries(create_convex_hull PUBLIC ${PROJECT_NAME}_core ${BULLET_LIBRARIES} tesseract::tesseract_common tesseract::tesseract_geometry ${Boost_LIBRARIES} console_bridge octomap octomath)
147+
target_link_libraries(create_convex_hull PUBLIC ${PROJECT_NAME}_core ${BULLET_LIBRARIES} tesseract::tesseract_common tesseract::tesseract_geometry ${Boost_LIBRARIES} console_bridge::console_bridge octomap octomath)
143148
target_compile_options(create_convex_hull PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE} ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
144149
target_compile_definitions(create_convex_hull PRIVATE ${TESSERACT_COMPILE_DEFINITIONS} ${BULLET_DEFINITIONS})
145150
target_clang_tidy(create_convex_hull ARGUMENTS ${TESSERACT_CLANG_TIDY_ARGS} ENABLE ${TESSERACT_ENABLE_CLANG_TIDY})

tesseract/tesseract_collision/cmake/tesseract_collision-config.cmake.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ link_directories(BEFORE ${FCL_LIBRARY_DIRS})
2727
include_directories(BEFORE "${BULLET_ROOT_DIR}/${BULLET_INCLUDE_DIRS}")
2828
link_directories(BEFORE "${BULLET_ROOT_DIR}/${BULLET_LIBRARY_DIRS}")
2929

30+
if(NOT TARGET console_bridge::console_bridge)
31+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
32+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
33+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
34+
endif()
35+
3036
# These targets are necessary for 16.04 builds. Remove when Kinetic support is dropped
3137
if(NOT TARGET octomap)
3238
add_library(octomap INTERFACE IMPORTED)

tesseract/tesseract_collision/examples/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
add_executable(${PROJECT_NAME}_box_box_example box_box_example.cpp)
2-
target_link_libraries(${PROJECT_NAME}_box_box_example ${PROJECT_NAME}_bullet ${PROJECT_NAME}_fcl tesseract::tesseract_geometry console_bridge ${BULLET_LIBRARIES} ${Boost_LIBRARIES} octomap octomath ${LIBFCL_LIBRARIES})
2+
target_link_libraries(${PROJECT_NAME}_box_box_example ${PROJECT_NAME}_bullet ${PROJECT_NAME}_fcl tesseract::tesseract_geometry console_bridge::console_bridge ${BULLET_LIBRARIES} ${Boost_LIBRARIES} octomap octomath ${LIBFCL_LIBRARIES})
33
target_compile_options(${PROJECT_NAME}_box_box_example PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE} ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
44
target_clang_tidy(${PROJECT_NAME}_box_box_example ARGUMENTS ${TESSERACT_CLANG_TIDY_ARGS} ENABLE ${TESSERACT_ENABLE_CLANG_TIDY})
55
target_cxx_version(${PROJECT_NAME}_box_box_example PRIVATE VERSION ${TESSERACT_CXX_VERSION})

tesseract/tesseract_collision/test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ include(GoogleTest)
4141

4242
macro(add_gtest test_name test_file)
4343
add_executable(${test_name} ${test_file})
44-
target_link_libraries(${test_name} PRIVATE GTest::GTest GTest::Main ${PROJECT_NAME}_test_suite ${PROJECT_NAME}_bullet ${PROJECT_NAME}_fcl tesseract::tesseract_geometry tesseract::tesseract_scene_graph console_bridge ${Boost_LIBRARIES} octomap octomath ${LIBFCL_LIBRARIES})
44+
target_link_libraries(${test_name} PRIVATE GTest::GTest GTest::Main ${PROJECT_NAME}_test_suite ${PROJECT_NAME}_bullet ${PROJECT_NAME}_fcl tesseract::tesseract_geometry tesseract::tesseract_scene_graph console_bridge::console_bridge ${Boost_LIBRARIES} octomap octomath ${LIBFCL_LIBRARIES})
4545
target_compile_options(${test_name} PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE} ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
4646
target_compile_definitions(${test_name} PRIVATE ${TESSERACT_COMPILE_DEFINITIONS})
4747
target_clang_tidy(${test_name} ARGUMENTS ${TESSERACT_CLANG_TIDY_ARGS} ENABLE ${TESSERACT_ENABLE_CLANG_TIDY})

tesseract/tesseract_environment/CMakeLists.txt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ find_package(tesseract_scene_graph REQUIRED)
1414
find_package(tesseract_common REQUIRED)
1515
find_package(cmake_common_scripts REQUIRED)
1616

17+
if(NOT TARGET console_bridge::console_bridge)
18+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
19+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
20+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
21+
endif()
22+
1723
set(COVERAGE_EXCLUDE /usr/* /opt/* ${CMAKE_CURRENT_LIST_DIR}/test/* /*/gtest/* /*/bullet/LinearMath/* /*/bullet/BulletCollision/*)
1824

1925
add_code_coverage_all_targets(EXCLUDE ${COVERAGE_EXCLUDE})
@@ -37,7 +43,7 @@ target_include_directories(${PROJECT_NAME}_core SYSTEM PUBLIC
3743
${EIGEN3_INCLUDE_DIRS})
3844

3945
add_library(${PROJECT_NAME}_kdl src/kdl/kdl_state_solver.cpp)
40-
target_link_libraries(${PROJECT_NAME}_kdl PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_scene_graph orocos-kdl console_bridge)
46+
target_link_libraries(${PROJECT_NAME}_kdl PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_scene_graph orocos-kdl console_bridge::console_bridge)
4147
target_compile_options(${PROJECT_NAME}_kdl PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE})
4248
target_compile_options(${PROJECT_NAME}_kdl PUBLIC ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
4349
target_compile_definitions(${PROJECT_NAME}_kdl PUBLIC ${TESSERACT_COMPILE_DEFINITIONS})
@@ -52,7 +58,7 @@ target_include_directories(${PROJECT_NAME}_kdl SYSTEM PUBLIC
5258
${orocos_kdl_INCLUDE_DIRS}) # Orocos did not export target correctly
5359

5460
add_library(${PROJECT_NAME}_ofkt src/ofkt/ofkt_state_solver.cpp src/ofkt/ofkt_nodes.cpp)
55-
target_link_libraries(${PROJECT_NAME}_ofkt PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_scene_graph console_bridge)
61+
target_link_libraries(${PROJECT_NAME}_ofkt PUBLIC ${PROJECT_NAME}_core tesseract::tesseract_scene_graph console_bridge::console_bridge)
5662
target_compile_options(${PROJECT_NAME}_ofkt PRIVATE ${TESSERACT_COMPILE_OPTIONS_PRIVATE})
5763
target_compile_options(${PROJECT_NAME}_ofkt PUBLIC ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
5864
target_compile_definitions(${PROJECT_NAME}_ofkt PUBLIC ${TESSERACT_COMPILE_DEFINITIONS})

tesseract/tesseract_environment/cmake/tesseract_environment-config.cmake.in

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,10 @@ find_dependency(tesseract_collision)
1212
find_dependency(tesseract_scene_graph)
1313
find_dependency(tesseract_common)
1414

15+
if(NOT TARGET console_bridge::console_bridge)
16+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
17+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
18+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
19+
endif()
20+
1521
include("${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@-targets.cmake")

tesseract/tesseract_geometry/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ find_package(cmake_common_scripts REQUIRED)
1515
find_package(assimp REQUIRED)
1616
link_directories(${assimp_LIBRARY_DIRS})
1717

18+
if(NOT TARGET console_bridge::console_bridge)
19+
add_library(console_bridge::console_bridge INTERFACE IMPORTED)
20+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${console_bridge_INCLUDE_DIRS}")
21+
set_target_properties(console_bridge::console_bridge PROPERTIES INTERFACE_LINK_LIBRARIES "${console_bridge_LIBRARIES}")
22+
endif()
23+
1824
# These targets are necessary for 16.04 builds. Remove when Kinetic support is dropped
1925
if(NOT TARGET octomap)
2026
add_library(octomap INTERFACE IMPORTED)
@@ -35,7 +41,7 @@ add_code_coverage_all_targets(EXCLUDE ${COVERAGE_EXCLUDE})
3541
tesseract_variables()
3642

3743
add_library(${PROJECT_NAME} INTERFACE)
38-
target_link_libraries(${PROJECT_NAME} INTERFACE tesseract::tesseract_common console_bridge octomap octomath ${assimp_LIBRARIES})
44+
target_link_libraries(${PROJECT_NAME} INTERFACE tesseract::tesseract_common console_bridge::console_bridge octomap octomath ${assimp_LIBRARIES})
3945
target_compile_options(${PROJECT_NAME} INTERFACE ${TESSERACT_COMPILE_OPTIONS_PUBLIC})
4046
target_compile_definitions(${PROJECT_NAME} INTERFACE ${TESSERACT_COMPILE_DEFINITIONS})
4147
target_clang_tidy(${PROJECT_NAME} ARGUMENTS ${TESSERACT_CLANG_TIDY_ARGS} ENABLE ${TESSERACT_ENABLE_CLANG_TIDY})

0 commit comments

Comments
 (0)