Skip to content

Commit 61b73e3

Browse files
Update use of target_code_coverage to fix codecov build
1 parent 787c45d commit 61b73e3

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

.github/workflows/ubuntu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
target-args: --cmake-args -DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }} -DBUILD_TESTING=ON -DENABLE_CLANG_TIDY=ON -DENABLE_CODE_COVERAGE=ON -DENABLE_CPACK=ON
5252

5353
- name: CodeCov
54-
if: matrix.distro == 'noble'
54+
if: matrix.distro == 'jammy'
5555
working-directory: target_ws
5656
shell: bash
5757
run: |

CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ target_link_libraries(${PROJECT_NAME} PUBLIC Boost::boost Boost::filesystem ${CM
3939
target_compile_definitions(${PROJECT_NAME} PUBLIC ${COMPILE_DEFINITIONS})
4040
target_cxx_version(${PROJECT_NAME} PUBLIC VERSION 17)
4141
target_clang_tidy(${PROJECT_NAME} ENABLE ${ENABLE_CLANG_TIDY})
42-
target_code_coverage(${PROJECT_NAME} ALL ENABLE ${ENABLE_CODE_COVERAGE})
42+
target_code_coverage(
43+
${PROJECT_NAME}
44+
PRIVATE
45+
ALL
46+
ENABLE ${ENABLE_CODE_COVERAGE})
4347

4448
# Build examples
4549
add_subdirectory(examples)

test/CMakeLists.txt

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,11 @@ target_compile_definitions(${PROJECT_NAME}_plugin_loader_unit PRIVATE PLUGIN_DIR
1313
PLUGINS="${PROJECT_NAME}_test_plugin_multiply")
1414
target_clang_tidy(${PROJECT_NAME}_plugin_loader_unit ENABLE ${ENABLE_CLANG_TIDY})
1515
target_cxx_version(${PROJECT_NAME}_plugin_loader_unit PUBLIC VERSION 17)
16-
target_code_coverage(${PROJECT_NAME}_plugin_loader_unit ALL ENABLE ${ENABLE_CODE_COVERAGE})
16+
target_code_coverage(
17+
${PROJECT_NAME}_plugin_loader_unit
18+
PRIVATE
19+
ALL
20+
ENABLE ${ENABLE_CODE_COVERAGE})
1721
add_gtest_discover_tests(${PROJECT_NAME}_plugin_loader_unit)
1822
add_dependencies(${PROJECT_NAME}_plugin_loader_unit ${PROJECT_NAME})
1923
add_dependencies(run_tests ${PROJECT_NAME}_plugin_loader_unit)
@@ -28,7 +32,11 @@ target_link_libraries(
2832
target_compile_definitions(${PROJECT_NAME}_plugin_loader_anchor_unit PRIVATE ${COMPILE_DEFINITIONS})
2933
target_clang_tidy(${PROJECT_NAME}_plugin_loader_anchor_unit ENABLE ${ENABLE_CLANG_TIDY})
3034
target_cxx_version(${PROJECT_NAME}_plugin_loader_anchor_unit PUBLIC VERSION 17)
31-
target_code_coverage(${PROJECT_NAME}_plugin_loader_anchor_unit ALL ENABLE ${ENABLE_CODE_COVERAGE})
35+
target_code_coverage(
36+
${PROJECT_NAME}_plugin_loader_anchor_unit
37+
PRIVATE
38+
ALL
39+
ENABLE ${ENABLE_CODE_COVERAGE})
3240
add_gtest_discover_tests(${PROJECT_NAME}_plugin_loader_anchor_unit)
3341
add_dependencies(${PROJECT_NAME}_plugin_loader_anchor_unit ${PROJECT_NAME})
3442
add_dependencies(run_tests ${PROJECT_NAME}_plugin_loader_anchor_unit)

0 commit comments

Comments
 (0)