Request: Charge tracking merge

[Dulanic]

So this isn't really a bug persay... but I have run into situations where there may be connectivity issues etc.. that cause teslamate to split the charge to 2 separate charges. I'd like the ability to "merge" charges.

I manually merged some this morning where I had 4 separate charges, but it was really only 1. This was due to issues /w my server and router, but I think it would be a good option to have. I'm not sure how feasible this is, but it was doable /w SQL and some update statements.

Note: Sorry I messed up and didn't click request! Feel free to correct.

[tabascoeye]

on a similar note: I think that all the micro-charges when leaving the car plugged in could be counted/merged into one. That would give a more realistic sum of charges.
Even though it's technically more correct to count them individually… hmmm

[kevinelliott]

Perhaps both should occur... micro-charges wrapped into a charge. Thus, later you could drill into the micro-charges since that is the truly correct underlying values, but the overall charge can be viewed in the UI more appropriately/first.

[bikeymouse]

I would also vote to have the option to merge consecutive charges with no activities in between, in the dashboard to one charge.

In my case, I have the charging being started and stopped based on the power from my solar panels. So this can result in 4 or 5 "charges" during a charging session, however these are no "micro" charges.

My suggestion would be to combine all charges in the dashboard as long as the charging cable is not disconnected in between.

Alternatively perhaps you combine charges if the starting charge-level of a charge is >= end charge-level of the previous charge (the idea being that there was no activity that used power in between).

[Dulanic]

@adriankumpf Just a example of why this would be nice... ex was at a destionation charger, and i guess it kept "topping" off my car?

[adriankumpf]

I think there are different opinions on this topic. Not everyone wants certain charges to be merged automatically. So I can only imagine that there would have to be a UI outside Grafana to selectively merge charges manually. PRs welcome!

[Dulanic]

So I am thinking a procedure would work.... any feedback anyone? Would need to set the beg and end charge id... then we just need to call the procedure? Seems to be functioning. I doin't know how to do it in elixir so thats why I did this in SQL...

CREATE 
OR REPLACE PROCEDURE public.combine_charges(
  beg_charging_processes_id integer, 
  end_charging_processes_id integer
) 
LANGUAGE 'plpgsql' 
AS $BODY$ 
begin 

-- check date difference.... if > 1 then return error
if (select max(end_date)::date - min(start_date)::date from charging_processes where id between beg_charging_processes_id and end_charging_processes_id) > 1 THEN
	RAISE EXCEPTION  'Start and end date is more than 1 day apart, please correct';
end if;

-- Update max process id using the range of IDs
update 
  charging_processes
set 
  start_date = updated.start_date, 
  end_date = updated.end_date, 
  start_ideal_range_km = updated.start_ideal_range_km, 
  end_ideal_range_km = updated.end_ideal_range_km, 
  start_rated_range_km = updated.start_rated_range_km, 
  end_rated_range_km = updated.end_rated_range_km, 
  start_battery_level = updated.start_battery_level, 
  end_battery_level = updated.end_battery_level, 
  outside_temp_avg = updated.outside_temp_avg, 
  charge_energy_added = updated.charge_energy_added, 
  duration_min = updated.duration_min 
from 
  (
    select 
      max(charging_process_id) as charging_process_id, 
      min(date) as start_date, 
      max(date) as end_date, 
      min(ideal_battery_range_km) as start_ideal_range_km, 
      max(ideal_battery_range_km) as end_ideal_range_km, 
      min(rated_battery_range_km) as start_rated_range_km, 
      max(rated_battery_range_km) as end_rated_range_km, 
      min(battery_level) as start_battery_level, 
      min(battery_level) as end_battery_level, 
      avg(outside_temp) as outside_temp_avg, 
      MAX(charge_energy_added) - MIN(charge_energy_added) as charge_energy_added, 
      EXTRACT(EPOCH  FROM  (max(date) - min(date)))/ 60 as duration_min 
    from 
      charges c 
    where 
      c.charging_process_id between beg_charging_processes_id and end_charging_processes_id
  ) as updated 
where 
  charging_processes.id = updated.charging_process_id;

--update all records to show the max id now.
update 
  charges
set 
  charging_process_id = end_charging_processes_id 
where 
  charging_process_id between beg_charging_processes_id and end_charging_processes_id; 
 
--delete all but the max id as they are now combined. 
delete from 
  charging_processes
where 
  id between beg_charging_processes_id 
  and end_charging_processes_id - 1;
  
end;
$BODY$;

[bbock]

Nice one, thanks.

Accoding to my data, summing up the charge_energy_added does create slightly wrong numbers (haven't investigated the exact source of the error, though). Therefore, I have modified it to sum up the energy from the charging_processes table instead and also to sum up charging costs instead of taking the last one.

I also made a similar one for drives.

See my source here.

[Gerben321]

Would be great if this would be accessible via the GUI. Works great if I call it via pgAdmin, but that's not always easy to do.

[Dulanic]

I do see one error that its not updating charge_energy_used so Ill work on that.

[chhitz]

I use the following script to merge charges:

#!/bin/sh

start_id=$1
end_id=$2

docker-compose exec database psql teslamate teslamate -c \
    "update charges set charging_process_id = $start_id \
        where charging_process_id between $start_id and $end_id;"

docker-compose exec teslamate bin/teslamate rpc \
    "TeslaMate.Repo.get(TeslaMate.Log.ChargingProcess, $start_id) \
        |> TeslaMate.Log.complete_charging_process()"

docker-compose exec database psql teslamate teslamate -c \
    "delete from charging_processes where id between $start_id + 1 and $end_id;"

[pencilheart]

Thanks, it works!

[swiffer]

Instead of modifying data I've opted into detecting consecutive charges for Charge / Discharge Stats in Charging Stats Dashboards via #4791.

This could be rolled out to other panels by introducing a Dashboard variable "Combine consecutive charges" leaving it up to users if they want to see those charging processes combined or not.