Skip to content

Errorneous return type for findByUserIdAndEntityId in instance permission repositories #1035

@ahennr

Description

@ahennr

Currently, UserInstancePermissionRepository and GroupInstancePermissionRepository return an Optional containing a single instance permission.

Optional<UserInstancePermission> findByUserIdAndEntityId(Long userId, Long entityId);
Optional<GroupInstancePermission> findByUserIdAndEntityId(Long userId, Long entityId);

However, a user / group may have multiple permissions for an entity, e.g. READ and UPDATE. So, a list should be returned here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions