Merge pull request #852 from terrestris/dev-deps

Chore(next): Include react specific eslint v9 rules

Author: ahennr

.husky/commit-msg

@@ -1,4 +1,4 @@
-# diasble CI
+# disable CI
 [ -n "$CI" ] && exit 0
 
 npx --no-install commitlint --edit $1

babel.config.js

@@ -5,9 +5,8 @@ module.exports = {
     '@babel/preset-react'
   ],
   plugins: [
-    '@babel/transform-class-properties',
-    '@babel/proposal-object-rest-spread',
-    '@babel/proposal-optional-chaining',
+    '@babel/plugin-transform-optional-chaining',
+    ['@babel/plugin-transform-class-properties', { loose: false }],
     [
       'import',
       {

eslint.config.mjs

@@ -1,7 +1,10 @@
 // @ts-check
 import globals from 'globals';
+import reactHooks from 'eslint-plugin-react-hooks';
 import importPlugin from 'eslint-plugin-import';
+import eslintReact from 'eslint-plugin-react';
 import eslintTerrestris from '@terrestris/eslint-config-typescript';
+import eslintReactTerrestris from '@terrestris/eslint-config-typescript-react';
 import eslint from '@eslint/js';
 import tsEslint from 'typescript-eslint';
 import stylisticEslint from '@stylistic/eslint-plugin'
@@ -14,28 +17,47 @@ export default tsEslint.config({
     importPlugin.flatConfigs.recommended
   ],
   files: [
-    '**/*.ts'
+    '**/*.{ts,tsx}'
   ],
   ignores: [
-    '**/*.spec.ts',
-    '**/jest/__mocks__/*.ts'
+    '**/test/setup.ts',
+    '**/e2e-tests/**.ts',
+    '**/global-setup.ts',
+    '**/playwright.config.ts',
+    '**/*.spec.{ts,tsx}',
+    'coverage/**/*.{js,ts*}',
+    'dist/**/*.{js,ts*}'
   ],
+  settings: {
+    react: {
+      version: 'detect'
+    }
+  },
   languageOptions: {
     ecmaVersion: 2022,
     globals: globals.browser,
     parserOptions: {
       project: true,
       tsconfigRootDir: import.meta.dirname
-    },
+    }
   },
   plugins: {
-    '@stylistic': stylisticEslint
+    'react-hooks': reactHooks,
+    '@stylistic': stylisticEslint,
+    react: eslintReact,
+    '@typescript-eslint/eslint-plugin': tsEslint
   },
   rules: {
     ...eslintTerrestris.rules,
-    '@typescript-eslint/member-ordering': 'off',
+    ...eslintReactTerrestris.rules,
+    ...reactHooks.configs.recommended.rules,
+    'react/jsx-closing-tag-location': ['warn'],
+    'react/jsx-closing-bracket-location': ['warn'],
+    'react-hooks/rules-of-hooks': ['warn'],
+    'react-hooks/exhaustive-deps': ['warn'],
     '@typescript-eslint/no-empty-object-type': 'off',
     '@typescript-eslint/no-unused-vars': 'warn',
+    'import/no-named-as-default': 'off',
     'import/no-unresolved': 'off',
     'import/named': 'off',
     'import/order': ['warn', {

jest.config.js

@@ -18,7 +18,6 @@ module.exports = {
     '^.+\\.tsx?$': 'babel-jest'
   },
   moduleNameMapper: {
-    // eslint-disable-next-line max-len
     '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': '<rootDir>/test/__mocks__/fileMock.js',
     '\\.(css|less|scss)$': '<rootDir>/test/__mocks__/styleMock.js',
     'shogunApplicationConfig': '<rootDir>/assets/fallbackConfig.js'