Skip to content

Update doc and validation of HPCS backup encryption keys #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

dishankkalra23
Copy link
Member

@dishankkalra23 dishankkalra23 commented Jun 28, 2024

Description

  1. Update the description and add validation for KP and HPCS in the backup_encryption_key_crn variable
  2. Removes validation for kms_key_crn when backup_encryption_key_crn is not available in the main configuration of the module

GE Issue - https://github.ibm.com/GoldenEye/issues/issues/9359

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Enhancements:

  1. Updated description and Validation for the backup_encryption_key_crn variable to ensure both Key Protect and HPCS keys follow the proper format.
  2. Updated validation logic for the backup_encryption_key_crn in the main configuration. If no value is provided, the module will now default to using kms_key_crn for both Key Protect and HPCS as the backup encryption key.
  3. Updated the FSCloud submodule and its associated example to integrate the use of HPCS keys for backup encryption.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@dishankkalra23 dishankkalra23 changed the title update backup encryption key description and validation Update doc and validation of HPCS backup encryption keys Jun 28, 2024
@dishankkalra23
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 7998909 into main Jun 28, 2024
2 checks passed
@ocofaigh ocofaigh deleted the update_hpcs_var branch June 28, 2024 09:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants