Skip to content

Commit d151c57

Browse files
bksagarSagar BKNupur Goyal
authored
fix: Onboard DA pipeline for tile version
* Additional changes added to push the new product version * indentation fix * Updating the changes from private repo --------- Co-authored-by: Sagar BK <Sagar.BK1@ibm.com> Co-authored-by: Nupur Goyal <nupurgoyal@Nupurs-MacBook-Pro.local>
1 parent 8ceb3b2 commit d151c57

File tree

10 files changed

+23
-34
lines changed

10 files changed

+23
-34
lines changed

.catalog-onboard-pipeline.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
apiVersion: v1
33
offerings:
44
# below is an example of a Deployable Architecture (DA) solution
5-
- name: deploy-arch-ibm-hpc # must match the offering name in the ibm_catalog.json
5+
- name: deploy-arch-ibm-hpc-lsf # must match the offering name in the ibm_catalog.json
66
kind: solution
7-
catalog_id: 8611e025-10b2-488e-8261-a7f584a5114b
8-
offering_id: bf3c07f8-5a62-4289-8ea0-94dbb2b410e6
7+
catalog_id: 0d89ec0d-d39a-494d-ac5b-9d940d8cc65f
8+
offering_id: 1444e20a-af22-40d1-af98-c880918849cb
99
# list all of the variations (flavors) you have included in the ibm_catalog.json
1010
variations:
1111
- name: Cluster-with-LSF

.releaserc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
}],
1111
["@semantic-release/exec", {
1212
"successCmd": "echo \"SEMVER_VERSION=${nextRelease.version}\" >> $GITHUB_ENV",
13-
"publishCmd": "./ci/trigger-catalog-onboarding-pipeline.sh --version=v${nextRelease.version}"
13+
"publishCmd": "./ci/trigger-catalog-onboarding-pipeline.sh --version=${nextRelease.version}"
1414
}]
1515
]
1616
}

.tekton/scripts/common_utils.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,5 @@ ibmcloud plugin install vpc-infrastructure -f
6262
ibmcloud plugin install dns -f
6363
ibmcloud plugin install security-compliance -f
6464
ibmcloud plugin install key-protect -r "IBM Cloud" -f
65+
ibmcloud plugin install atracker -f
6566
echo "************************************************"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
data "ibm_resource_group" "itself" {
2-
name = var.resource_group
2+
name = var.existing_resource_group
33
}

examples/create_vpc/modules/landing_zone_vpc/locals.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ locals {
2121
var.allowed_cidr
2222
# var.network_cidr
2323
])
24-
resource_group_id = var.resource_group != null ? data.ibm_resource_group.itself.id : ""
24+
resource_group_id = var.existing_resource_group != null ? data.ibm_resource_group.itself.id : ""
2525

2626
# Region and Zone calculations
2727
region = join("-", slice(split("-", var.zones[0]), 0, 2))

examples/create_vpc/modules/landing_zone_vpc/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ variable "ibmcloud_api_key" {
1313
# Resource Groups Variables
1414
##############################################################################
1515

16-
variable "resource_group" {
16+
variable "existing_resource_group" {
1717
description = "String describing resource groups to create or reference"
1818
type = string
1919
default = null
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
module "create_vpc" {
2-
source = "../../modules/landing_zone_vpc"
3-
allowed_cidr = var.remote_allowed_ips
4-
ibmcloud_api_key = var.ibmcloud_api_key
5-
ssh_keys = var.bastion_ssh_keys
6-
prefix = var.cluster_prefix
7-
resource_group = var.resource_group
8-
zones = var.zones
9-
network_cidr = var.vpc_cidr
10-
bastion_subnets_cidr = var.vpc_cluster_login_private_subnets_cidr_blocks
11-
compute_subnets_cidr = var.vpc_cluster_private_subnets_cidr_blocks
12-
enable_hub = var.enable_hub
2+
source = "../../modules/landing_zone_vpc"
3+
allowed_cidr = var.remote_allowed_ips
4+
ibmcloud_api_key = var.ibmcloud_api_key
5+
ssh_keys = var.bastion_ssh_keys
6+
prefix = var.cluster_prefix
7+
existing_resource_group = var.existing_resource_group
8+
zones = var.zones
9+
network_cidr = var.vpc_cidr
10+
bastion_subnets_cidr = var.vpc_cluster_login_private_subnets_cidr_blocks
11+
compute_subnets_cidr = var.vpc_cluster_private_subnets_cidr_blocks
12+
enable_hub = var.enable_hub
1313
}

examples/create_vpc/solutions/hpc/variables.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ variable "ibmcloud_api_key" {
1616
# Resource Groups Variables
1717
##############################################################################
1818

19-
variable "resource_group" {
19+
variable "existing_resource_group" {
2020
description = "Resource group name from your IBM Cloud account where the VPC resources should be deployed. Note. If the resource group value is set as null, automation creates two different RG with the name (workload-rg and service-rg). For additional information on resource groups, see [Managing resource groups](https://cloud.ibm.com/docs/account?topic=account-rgs)."
2121
type = string
2222
default = "Default"
2323
validation {
24-
condition = var.resource_group != null
25-
error_message = "If you want to provide null for resource_group variable, it should be within double quotes."
24+
condition = var.existing_resource_group != null
25+
error_message = "If you want to provide null for existing_resource_group variable, it should be within double quotes."
2626
}
2727
}
2828

ibm_catalog.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -158,18 +158,6 @@
158158
"displayname": "London 3",
159159
"value": ["eu-gb-3"]
160160
},
161-
{
162-
"displayname": "Frankfurt 1",
163-
"value": ["eu-de-1"]
164-
},
165-
{
166-
"displayname": "Frankfurt 2",
167-
"value": ["eu-de-2"]
168-
},
169-
{
170-
"displayname": "Frankfurt 3",
171-
"value": ["eu-de-3"]
172-
},
173161
{
174162
"displayname": "Sydney 1",
175163
"value": ["au-syd-1"]

solutions/hpc/catalogValidationValues.json.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"ibmcloud_api_key": $VALIDATION_APIKEY,
33
"existing_resource_group": $RG_NAME,
4-
"reservation_id": $HPC_RESERVATION_ID,
4+
"ibm_customer_number": $HPC_IBM_CUSTOMER_NUMBER,
55
"cluster_name": "HPC-LSF-1",
66
"bastion_ssh_keys": "[\"geretain-hpc\"]",
77
"compute_ssh_keys": "[\"geretain-hpc\"]",

0 commit comments

Comments
 (0)