Skip to content

feat: add support for config aggregator #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2025
Merged

feat: add support for config aggregator #214

merged 6 commits into from
May 2, 2025

Conversation

ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Apr 30, 2025

Description

See #213

NOTE: Enterprise support will be coming in a subsequent PR

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh requested review from jor2 and removed request for MatthewLemmond and Aayush-Abhyarthi April 30, 2025 17:03
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

As expected upgrade test failed since the directory of example was renamed. Low risk since not changing any current module code (just adding new code to enable config aggregator and create a trusted profile), so skipping

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh requested a review from MatthewLemmond April 30, 2025 17:20
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh marked this pull request as draft May 2, 2025 15:11
@ocofaigh
Copy link
Contributor Author

ocofaigh commented May 2, 2025

Going to add enterprise support to this PR

@ocofaigh ocofaigh marked this pull request as ready for review May 2, 2025 19:34
@ocofaigh
Copy link
Contributor Author

ocofaigh commented May 2, 2025

/run pipeline

Copy link
Member

@MatthewLemmond MatthewLemmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small points, not sure on the enterprise comment but wanted to double check

@ocofaigh
Copy link
Contributor Author

ocofaigh commented May 2, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 1defaa0 into main May 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the aggre branch May 2, 2025 20:06
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants