feat: enable cloud shell api calls (#135)

Author: vburckhardt

README.md

@@ -192,7 +192,7 @@ No resources.
 | <a name="input_serviceid_creation"></a> [serviceid\_creation](#input\_serviceid\_creation) | When restriction is enabled, only users, including the account owner, assigned the Service ID creator role on the IAM Identity Service can create service IDs. Allowed values are 'RESTRICTED', 'NOT\_RESTRICTED', or 'NOT\_SET' (to 'unset' a previous set value). | `string` | `"RESTRICTED"` | no |
 | <a name="input_shell_settings_enabled"></a> [shell\_settings\_enabled](#input\_shell\_settings\_enabled) | Enable global shell settings to all users in the account | `bool` | `false` | no |
 | <a name="input_skip_atracker_cos_iam_auth_policy"></a> [skip\_atracker\_cos\_iam\_auth\_policy](#input\_skip\_atracker\_cos\_iam\_auth\_policy) | Set to true to skip the creation of an IAM authorization policy that permits the Activity Tracker service Object Writer access to the Cloud Object Storage instance provisioned by this module. NOTE: If skipping, you must ensure the auth policy exists on the account before running the module. | `bool` | `false` | no |
-| <a name="input_skip_cloud_shell_calls"></a> [skip\_cloud\_shell\_calls](#input\_skip\_cloud\_shell\_calls) | Skip Cloud Shell calls in the account. | `bool` | `true` | no |
+| <a name="input_skip_cloud_shell_calls"></a> [skip\_cloud\_shell\_calls](#input\_skip\_cloud\_shell\_calls) | Skip Cloud Shell calls in the account. | `bool` | `false` | no |
 | <a name="input_skip_cos_kms_auth_policy"></a> [skip\_cos\_kms\_auth\_policy](#input\_skip\_cos\_kms\_auth\_policy) | Whether to enable creating an IAM authoriation policy between the IBM Cloud Object Storage instance and the Key Management service instance of the CRN provided in `kms_key_crn`. This variable has no effect if `provision_atracker_cos` is false. | `bool` | `false` | no |
 | <a name="input_trusted_profile_description"></a> [trusted\_profile\_description](#input\_trusted\_profile\_description) | Description of the trusted profile. | `string` | `"Trusted Profile for Projects access"` | no |
 | <a name="input_trusted_profile_name"></a> [trusted\_profile\_name](#input\_trusted\_profile\_name) | Name of the trusted profile, required if `provision_trusted_profile_projects` is true. | `string` | `null` | no |

solutions/account-infrastructure-base/main.tf

@@ -61,6 +61,7 @@ module "account_infrastructure_base" {
   refresh_token_expiration     = var.refresh_token_expiration
   serviceid_creation           = var.serviceid_creation
   shell_settings_enabled       = var.shell_settings_enabled
+  skip_cloud_shell_calls       = var.skip_cloud_shell_calls
   user_mfa                     = var.user_mfa
   user_mfa_reset               = var.user_mfa_reset
 

solutions/account-infrastructure-base/variables.tf

@@ -175,6 +175,12 @@ variable "shell_settings_enabled" {
   default     = false
 }
 
+variable "skip_cloud_shell_calls" {
+  type        = bool
+  description = "Skip Cloud Shell calls in the account."
+  default     = false
+}
+
 variable "user_mfa" {
   type = set(object({
     iam_id = string

variables.tf

@@ -160,7 +160,7 @@ variable "shell_settings_enabled" {
 variable "skip_cloud_shell_calls" {
   type        = bool
   description = "Skip Cloud Shell calls in the account."
-  default     = true
+  default     = false
 }
 
 variable "user_mfa" {