Skip to content

feat: used en latest version_locator and used cos instance created by obs d… #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 13, 2024

Conversation

Soaib024
Copy link
Member

@Soaib024 Soaib024 commented Jun 7, 2024

used EN latest version_locator and passed cos instance created by obs DA to EN

Description

#9

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Soaib024
Copy link
Member Author

Soaib024 commented Jun 7, 2024

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024
Copy link
Member Author

Soaib024 commented Jun 12, 2024

Changes:

  • Updated core-security-services-en version_locator to latest (v1.5).
  • Passed CRN of COS instance created by core-security-observability to core-security-services-en.
  • Skipped COS-KMS auth creation in core-security-services-en as that will be created by core-security-observability.
  • core-security-services-en is already using KMS created by core-security-services-kms, so no changes required.

Note:
The names of the stack elements are:
1-core-security-services-kms
3-core-security-observability
2-core-security-services-en

Now, EN is dependent on observability, so should we change the name to 2-core-security-observability and 3-core-security-services-en to reflect the actual order of the stack? @ocofaigh @tyao117

@Soaib024 Soaib024 marked this pull request as ready for review June 12, 2024 06:11
@Soaib024 Soaib024 changed the title used en latest version_locator and used cos instance created by obs d… feat: used en latest version_locator and used cos instance created by obs d… Jun 12, 2024
@ocofaigh
Copy link
Contributor

@Soaib024 I created an issue to update the member names: #34

However for this PR, lets just keep current naming and rename like you mentioned:

  • 2-core-security-observability
  • 3-core-security-services-en

We also need to update the diagram here to show the new COS flows for EN

@Soaib024 Soaib024 requested review from ocofaigh and removed request for ocofaigh June 12, 2024 08:52
@Soaib024
Copy link
Member Author

/run pipeline

@iamar7
Copy link
Member

iamar7 commented Jun 13, 2024

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

1 similar comment
@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024
Copy link
Member Author

/run pipeline

@Soaib024 Soaib024 requested a review from ocofaigh June 13, 2024 14:28
@ocofaigh ocofaigh merged commit 91b4939 into main Jun 13, 2024
2 checks passed
@ocofaigh ocofaigh deleted the fix-9172 branch June 13, 2024 16:34
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update stack to latest Event Notifications DA and handle the support for COS integration
4 participants