fix: Update CI workflow versions to remove deprecated runtime warnings (#2)

Author: bryantbiggs

.github/workflows/lock.yml

@@ -8,7 +8,7 @@ jobs:
   lock:
     runs-on: ubuntu-latest
     steps:
-      - uses: dessant/lock-threads@v4
+      - uses: dessant/lock-threads@v5
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           issue-comment: >

.github/workflows/pr-title.yml

@@ -14,7 +14,7 @@ jobs:
     steps:
       # Please look up the latest version from
       # https://github.com/amannn/action-semantic-pull-request/releases
-      - uses: amannn/action-semantic-pull-request@v5.0.2
+      - uses: amannn/action-semantic-pull-request@v5.4.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:

.github/workflows/pre-commit.yml

@@ -8,7 +8,7 @@ on:
 
 env:
   TERRAFORM_DOCS_VERSION: v0.16.0
-  TFLINT_VERSION: v0.44.1
+  TFLINT_VERSION: v0.50.3
 
 jobs:
   collectInputs:
@@ -18,11 +18,11 @@ jobs:
       directories: ${{ steps.dirs.outputs.directories }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Get root directories
         id: dirs
-        uses: clowdhaus/terraform-composite-actions/directories@v1.8.3
+        uses: clowdhaus/terraform-composite-actions/directories@v1.9.0
 
   preCommitMinVersions:
     name: Min TF pre-commit
@@ -32,19 +32,27 @@ jobs:
       matrix:
         directory: ${{ fromJson(needs.collectInputs.outputs.directories) }}
     steps:
+      # https://github.com/orgs/community/discussions/25678#discussioncomment-5242449
+      - name: Delete huge unnecessary tools folder
+        run: |
+          rm -rf /opt/hostedtoolcache/CodeQL
+          rm -rf /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk
+          rm -rf /opt/hostedtoolcache/Ruby
+          rm -rf /opt/hostedtoolcache/go
+
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Terraform min/max versions
         id: minMax
-        uses: clowdhaus/terraform-min-max@v1.2.4
+        uses: clowdhaus/terraform-min-max@v1.3.0
         with:
           directory: ${{ matrix.directory }}
 
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory !=  '.' }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.3
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.9.0
         with:
           terraform-version: ${{ steps.minMax.outputs.minVersion }}
           tflint-version: ${{ env.TFLINT_VERSION }}
@@ -53,7 +61,7 @@ jobs:
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.minVersion }}
         # Run only validate pre-commit check on min version supported
         if: ${{ matrix.directory ==  '.' }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.3
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.9.0
         with:
           terraform-version: ${{ steps.minMax.outputs.minVersion }}
           tflint-version: ${{ env.TFLINT_VERSION }}
@@ -64,18 +72,26 @@ jobs:
     runs-on: ubuntu-latest
     needs: collectInputs
     steps:
+      # https://github.com/orgs/community/discussions/25678#discussioncomment-5242449
+      - name: Delete huge unnecessary tools folder
+        run: |
+          rm -rf /opt/hostedtoolcache/CodeQL
+          rm -rf /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk
+          rm -rf /opt/hostedtoolcache/Ruby
+          rm -rf /opt/hostedtoolcache/go
+
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.head.ref }}
           repository: ${{github.event.pull_request.head.repo.full_name}}
 
       - name: Terraform min/max versions
         id: minMax
-        uses: clowdhaus/terraform-min-max@v1.2.4
+        uses: clowdhaus/terraform-min-max@v1.3.0
 
       - name: Pre-commit Terraform ${{ steps.minMax.outputs.maxVersion }}
-        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.8.3
+        uses: clowdhaus/terraform-composite-actions/pre-commit@v1.9.0
         with:
           terraform-version: ${{ steps.minMax.outputs.maxVersion }}
           tflint-version: ${{ env.TFLINT_VERSION }}

.github/workflows/release.yml

@@ -20,18 +20,18 @@ jobs:
     if: github.repository_owner == 'terraform-aws-modules'
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
           fetch-depth: 0
 
       - name: Release
-        uses: cycjimmy/semantic-release-action@v3
+        uses: cycjimmy/semantic-release-action@v4
         with:
-          semantic_version: 18.0.0
+          semantic_version: 23.0.2
           extra_plugins: |
-            @semantic-release/changelog@6.0.0
-            @semantic-release/git@10.0.0
-            conventional-changelog-conventionalcommits@4.6.3
+            @semantic-release/changelog@6.0.3
+            @semantic-release/git@10.0.1
+            conventional-changelog-conventionalcommits@7.0.2
         env:
           GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_TOKEN }}

.github/workflows/stale-actions.yaml

@@ -7,7 +7,7 @@ jobs:
   stale:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v6
+      - uses: actions/stale@v9
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
           # Staling issues and PR's

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/antonbabenko/pre-commit-terraform
-    rev: v1.81.0
+    rev: v1.88.0
     hooks:
       - id: terraform_fmt
       - id: terraform_wrapper_module_for_each
@@ -22,9 +22,11 @@ repos:
           - '--args=--only=terraform_required_providers'
           - '--args=--only=terraform_standard_module_structure'
           - '--args=--only=terraform_workspace_remote'
+          - '--args=--only=terraform_unused_required_providers'
       - id: terraform_validate
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v4.5.0
     hooks:
       - id: check-merge-conflict
       - id: end-of-file-fixer
+      - id: trailing-whitespace

README.md

@@ -94,7 +94,6 @@ Examples codified under the [`examples`](https://github.com/terraform-aws-module
 | Name | Version |
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.0 |
-| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.2 |
 
 ## Providers
 

versions.tf

@@ -1,10 +1,3 @@
 terraform {
   required_version = ">= 1.0"
-
-  required_providers {
-    aws = {
-      source  = "hashicorp/aws"
-      version = ">= 5.2"
-    }
-  }
 }

wrappers/firewall/main.tf

@@ -4,16 +4,16 @@ module "wrapper" {
   for_each = var.items
 
   create                                   = try(each.value.create, var.defaults.create, true)
-  tags                                     = try(each.value.tags, var.defaults.tags, {})
+  create_logging_configuration             = try(each.value.create_logging_configuration, var.defaults.create_logging_configuration, false)
   delete_protection                        = try(each.value.delete_protection, var.defaults.delete_protection, true)
   description                              = try(each.value.description, var.defaults.description, "")
   encryption_configuration                 = try(each.value.encryption_configuration, var.defaults.encryption_configuration, {})
   firewall_policy_arn                      = try(each.value.firewall_policy_arn, var.defaults.firewall_policy_arn, "")
   firewall_policy_change_protection        = try(each.value.firewall_policy_change_protection, var.defaults.firewall_policy_change_protection, null)
+  logging_configuration_destination_config = try(each.value.logging_configuration_destination_config, var.defaults.logging_configuration_destination_config, [])
   name                                     = try(each.value.name, var.defaults.name, "")
   subnet_change_protection                 = try(each.value.subnet_change_protection, var.defaults.subnet_change_protection, true)
   subnet_mapping                           = try(each.value.subnet_mapping, var.defaults.subnet_mapping, {})
+  tags                                     = try(each.value.tags, var.defaults.tags, {})
   vpc_id                                   = try(each.value.vpc_id, var.defaults.vpc_id, "")
-  create_logging_configuration             = try(each.value.create_logging_configuration, var.defaults.create_logging_configuration, false)
-  logging_configuration_destination_config = try(each.value.logging_configuration_destination_config, var.defaults.logging_configuration_destination_config, [])
 }

wrappers/main.tf

@@ -4,34 +4,34 @@ module "wrapper" {
   for_each = var.items
 
   create                                    = try(each.value.create, var.defaults.create, true)
-  tags                                      = try(each.value.tags, var.defaults.tags, {})
+  create_logging_configuration              = try(each.value.create_logging_configuration, var.defaults.create_logging_configuration, false)
+  create_policy                             = try(each.value.create_policy, var.defaults.create_policy, true)
+  create_policy_resource_policy             = try(each.value.create_policy_resource_policy, var.defaults.create_policy_resource_policy, false)
   delete_protection                         = try(each.value.delete_protection, var.defaults.delete_protection, true)
   description                               = try(each.value.description, var.defaults.description, "")
   encryption_configuration                  = try(each.value.encryption_configuration, var.defaults.encryption_configuration, {})
   firewall_policy_arn                       = try(each.value.firewall_policy_arn, var.defaults.firewall_policy_arn, "")
   firewall_policy_change_protection         = try(each.value.firewall_policy_change_protection, var.defaults.firewall_policy_change_protection, null)
-  name                                      = try(each.value.name, var.defaults.name, "")
-  subnet_change_protection                  = try(each.value.subnet_change_protection, var.defaults.subnet_change_protection, true)
-  subnet_mapping                            = try(each.value.subnet_mapping, var.defaults.subnet_mapping, {})
-  vpc_id                                    = try(each.value.vpc_id, var.defaults.vpc_id, "")
-  create_logging_configuration              = try(each.value.create_logging_configuration, var.defaults.create_logging_configuration, false)
   logging_configuration_destination_config  = try(each.value.logging_configuration_destination_config, var.defaults.logging_configuration_destination_config, [])
-  create_policy                             = try(each.value.create_policy, var.defaults.create_policy, true)
+  name                                      = try(each.value.name, var.defaults.name, "")
+  policy_attach_resource_policy             = try(each.value.policy_attach_resource_policy, var.defaults.policy_attach_resource_policy, false)
   policy_description                        = try(each.value.policy_description, var.defaults.policy_description, null)
   policy_encryption_configuration           = try(each.value.policy_encryption_configuration, var.defaults.policy_encryption_configuration, {})
+  policy_name                               = try(each.value.policy_name, var.defaults.policy_name, "")
+  policy_ram_resource_associations          = try(each.value.policy_ram_resource_associations, var.defaults.policy_ram_resource_associations, {})
+  policy_resource_policy                    = try(each.value.policy_resource_policy, var.defaults.policy_resource_policy, "")
+  policy_resource_policy_actions            = try(each.value.policy_resource_policy_actions, var.defaults.policy_resource_policy_actions, [])
+  policy_resource_policy_principals         = try(each.value.policy_resource_policy_principals, var.defaults.policy_resource_policy_principals, [])
   policy_stateful_default_actions           = try(each.value.policy_stateful_default_actions, var.defaults.policy_stateful_default_actions, [])
   policy_stateful_engine_options            = try(each.value.policy_stateful_engine_options, var.defaults.policy_stateful_engine_options, {})
   policy_stateful_rule_group_reference      = try(each.value.policy_stateful_rule_group_reference, var.defaults.policy_stateful_rule_group_reference, {})
   policy_stateless_custom_action            = try(each.value.policy_stateless_custom_action, var.defaults.policy_stateless_custom_action, {})
   policy_stateless_default_actions          = try(each.value.policy_stateless_default_actions, var.defaults.policy_stateless_default_actions, ["aws:pass"])
   policy_stateless_fragment_default_actions = try(each.value.policy_stateless_fragment_default_actions, var.defaults.policy_stateless_fragment_default_actions, ["aws:pass"])
   policy_stateless_rule_group_reference     = try(each.value.policy_stateless_rule_group_reference, var.defaults.policy_stateless_rule_group_reference, {})
-  policy_name                               = try(each.value.policy_name, var.defaults.policy_name, "")
   policy_tags                               = try(each.value.policy_tags, var.defaults.policy_tags, {})
-  create_policy_resource_policy             = try(each.value.create_policy_resource_policy, var.defaults.create_policy_resource_policy, false)
-  policy_resource_policy_actions            = try(each.value.policy_resource_policy_actions, var.defaults.policy_resource_policy_actions, [])
-  policy_resource_policy_principals         = try(each.value.policy_resource_policy_principals, var.defaults.policy_resource_policy_principals, [])
-  policy_attach_resource_policy             = try(each.value.policy_attach_resource_policy, var.defaults.policy_attach_resource_policy, false)
-  policy_resource_policy                    = try(each.value.policy_resource_policy, var.defaults.policy_resource_policy, "")
-  policy_ram_resource_associations          = try(each.value.policy_ram_resource_associations, var.defaults.policy_ram_resource_associations, {})
+  subnet_change_protection                  = try(each.value.subnet_change_protection, var.defaults.subnet_change_protection, true)
+  subnet_mapping                            = try(each.value.subnet_mapping, var.defaults.subnet_mapping, {})
+  tags                                      = try(each.value.tags, var.defaults.tags, {})
+  vpc_id                                    = try(each.value.vpc_id, var.defaults.vpc_id, "")
 }

wrappers/policy/main.tf

@@ -3,22 +3,22 @@ module "wrapper" {
 
   for_each = var.items
 
+  attach_resource_policy             = try(each.value.attach_resource_policy, var.defaults.attach_resource_policy, false)
   create                             = try(each.value.create, var.defaults.create, true)
-  tags                               = try(each.value.tags, var.defaults.tags, {})
+  create_resource_policy             = try(each.value.create_resource_policy, var.defaults.create_resource_policy, false)
   description                        = try(each.value.description, var.defaults.description, null)
   encryption_configuration           = try(each.value.encryption_configuration, var.defaults.encryption_configuration, {})
+  name                               = try(each.value.name, var.defaults.name, "")
+  ram_resource_associations          = try(each.value.ram_resource_associations, var.defaults.ram_resource_associations, {})
+  resource_policy                    = try(each.value.resource_policy, var.defaults.resource_policy, "")
+  resource_policy_actions            = try(each.value.resource_policy_actions, var.defaults.resource_policy_actions, [])
+  resource_policy_principals         = try(each.value.resource_policy_principals, var.defaults.resource_policy_principals, [])
   stateful_default_actions           = try(each.value.stateful_default_actions, var.defaults.stateful_default_actions, [])
   stateful_engine_options            = try(each.value.stateful_engine_options, var.defaults.stateful_engine_options, {})
   stateful_rule_group_reference      = try(each.value.stateful_rule_group_reference, var.defaults.stateful_rule_group_reference, {})
   stateless_custom_action            = try(each.value.stateless_custom_action, var.defaults.stateless_custom_action, {})
   stateless_default_actions          = try(each.value.stateless_default_actions, var.defaults.stateless_default_actions, ["aws:pass"])
   stateless_fragment_default_actions = try(each.value.stateless_fragment_default_actions, var.defaults.stateless_fragment_default_actions, ["aws:pass"])
   stateless_rule_group_reference     = try(each.value.stateless_rule_group_reference, var.defaults.stateless_rule_group_reference, {})
-  name                               = try(each.value.name, var.defaults.name, "")
-  create_resource_policy             = try(each.value.create_resource_policy, var.defaults.create_resource_policy, false)
-  resource_policy_actions            = try(each.value.resource_policy_actions, var.defaults.resource_policy_actions, [])
-  resource_policy_principals         = try(each.value.resource_policy_principals, var.defaults.resource_policy_principals, [])
-  attach_resource_policy             = try(each.value.attach_resource_policy, var.defaults.attach_resource_policy, false)
-  resource_policy                    = try(each.value.resource_policy, var.defaults.resource_policy, "")
-  ram_resource_associations          = try(each.value.ram_resource_associations, var.defaults.ram_resource_associations, {})
+  tags                               = try(each.value.tags, var.defaults.tags, {})
 }

wrappers/rule-group/main.tf

@@ -3,19 +3,19 @@ module "wrapper" {
 
   for_each = var.items
 
-  create                     = try(each.value.create, var.defaults.create, true)
-  tags                       = try(each.value.tags, var.defaults.tags, {})
+  attach_resource_policy     = try(each.value.attach_resource_policy, var.defaults.attach_resource_policy, false)
   capacity                   = try(each.value.capacity, var.defaults.capacity, 100)
+  create                     = try(each.value.create, var.defaults.create, true)
+  create_resource_policy     = try(each.value.create_resource_policy, var.defaults.create_resource_policy, false)
   description                = try(each.value.description, var.defaults.description, null)
   encryption_configuration   = try(each.value.encryption_configuration, var.defaults.encryption_configuration, {})
   name                       = try(each.value.name, var.defaults.name, "")
+  ram_resource_associations  = try(each.value.ram_resource_associations, var.defaults.ram_resource_associations, {})
+  resource_policy            = try(each.value.resource_policy, var.defaults.resource_policy, "")
+  resource_policy_actions    = try(each.value.resource_policy_actions, var.defaults.resource_policy_actions, [])
+  resource_policy_principals = try(each.value.resource_policy_principals, var.defaults.resource_policy_principals, [])
   rule_group                 = try(each.value.rule_group, var.defaults.rule_group, {})
   rules                      = try(each.value.rules, var.defaults.rules, null)
+  tags                       = try(each.value.tags, var.defaults.tags, {})
   type                       = try(each.value.type, var.defaults.type, "STATELESS")
-  create_resource_policy     = try(each.value.create_resource_policy, var.defaults.create_resource_policy, false)
-  resource_policy_actions    = try(each.value.resource_policy_actions, var.defaults.resource_policy_actions, [])
-  resource_policy_principals = try(each.value.resource_policy_principals, var.defaults.resource_policy_principals, [])
-  attach_resource_policy     = try(each.value.attach_resource_policy, var.defaults.attach_resource_policy, false)
-  resource_policy            = try(each.value.resource_policy, var.defaults.resource_policy, "")
-  ram_resource_associations  = try(each.value.ram_resource_associations, var.defaults.ram_resource_associations, {})
 }