SERVER ERROR: Not well formed WOQL JSON-LD #2156
Comments
|
I was quickly checking it, could you provide the similar output for the working example too for the similar query without js-style variables bindings (I.e. v:var notation)? It would help troubleshoot so that we can see the diff and see what needs to be done? |
|
I suspect this should be moved to the javascript client but let's confirm first! |
@hoijnet I updated the issue |
|
Thanks a lot, also for the diff. Should be possible to fix in the client and roll with the next release of it I hope! |
|
It's also working: let v = Vars("result1", "result2");
and(
evaluate(times(2,3), v.result1),
evaluate(times("v:result1",3), v.result2)
)But not this: let v = Vars("result1", "result2");
and(
evaluate(times(2,3), v.result1),
evaluate(times(v.result1,3), v.result2)
)And this is problem with every math operation: let v = Vars("result1", "result2");
and(
evaluate(minus(2,3), v.result1),
evaluate(minus(v.result1,3), v.result2)
) |
I did a first pass at checking it and there seems to be more to it than the example code, for which there is a clue in your diff. This works: let v = Vars("result1", "result2");
WOQL.limit(10).and(
WOQL.evaluate(WOQL.times(2,3), v.result1),
WOQL.evaluate(WOQL.times(v.result1,3), v.result2)
);This also works: let v = Vars("result1", "result2");
WOQL.limit(10).limit(10).and(
WOQL.evaluate(WOQL.times(2,3), v.result1),
WOQL.evaluate(WOQL.times(v.result1,3), v.result2)
);This works: let v = Vars("result1", "result2");
WOQL.count("v:Count").and(
WOQL.evaluate(WOQL.times(2,3), v.result1),
WOQL.evaluate(WOQL.times(v.result1,3), v.result2)
);This also works: let v = Vars("result1", "result2", "Count");
WOQL.count("v:Count").and(
WOQL.evaluate(WOQL.times(2,3), v.result1),
WOQL.evaluate(WOQL.times(v.result1,3), v.result2)
);This also works (as shown): WOQL.and(
WOQL.evaluate(WOQL.times(2,3), v.result1),
WOQL.evaluate(WOQL.times(v.result1,3), v.result2)
);Count you confirm that it is together with I have not been able to reproduce the issue getting "Value" with the example provided. The example provided does not correspond 1:1 with the WOQL output as there are multiple instances of Limit and Count that are not part of the original WOQL query. I'm unsure about why Value pops up instead of ArithmeticValue as I don't have an immediate explanation in the javascript code. Can you also confirm that you are using the latest client to rule out that potential issue. |
|
@hoijnet I added a PR to fix this completely. In the PR description I attach a test with proof that it works. |
alexander-mart
moved this from In Progress
to To review
in @alexander-mart's TerminusDB todo list
alexander-mart
moved this from To review
to Todo
in @alexander-mart's TerminusDB todo list
alexander-mart
moved this from Todo
to To review
in @alexander-mart's TerminusDB todo list
|
@alexander-mart , please check if you get the same behaviour with eval() as you get with evaluate()? I believe evaluate() should be deprecated and there should be only one, and well-functioning arithmetic evaluation, are you of the same view? |
|
With With |
|
Ok, that sounds promising! I assume this issue refers to the dashboard component and that we should rebuild it with the latest client then? |
Yes it is. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Query from documentation about math operators with js-style variables binding:
❌ Return:
Request payload from devtools:
{ "query": { "@type": "Limit", "limit": 10, "query": { "query": { "@type": "Limit", "limit": 10, "query": { "@type": "And", "and": [ { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 2 } }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result1" } }, { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "Value", "variable": "result1" }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result2" } } ] } } } } }Response from devtools:
{ "@type": "api:WoqlErrorResponse", "api:error": { "@type": "vio:WOQLSyntaxError", "vio:path": [ "and", 1, "query" ], "vio:query": { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "Value", "variable": "result1" }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result2" } } }, "api:message": "Not well formed WOQL JSON-LD", "api:status": "api:failure" }But similar query without js-style variables bindings:
✅ Return correct result:
[ { "result1": { "@type": "xsd:decimal", "@value": 6 }, "result2": { "@type": "xsd:decimal", "@value": 18 } } ]Request payload from devtools:
{ "query": { "@type": "Count", "count": { "@type": "Value", "variable": "Count" }, "query": { "@type": "And", "and": [ { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 2 } }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result1" } }, { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "ArithmeticValue", "variable": "result1" }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result2" } } ] } } }Difference between non-working (
-) and working (+) request{ "query": { - "@type": "Limit", - "limit": 10, + "@type": "Count", + "count": { + "@type": "Value", + "variable": "Count" + }, "query": { "@type": "And", "and": [ { "@type": "Eval", "expression": { "@type": "Times", "left": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 2 } }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result1" } }, { "@type": "Eval", "expression": { "@type": "Times", "left": { - "@type": "Value", + "@type": "ArithmeticValue", "variable": "result1" }, "right": { "@type": "ArithmeticValue", "data": { "@type": "xsd:decimal", "@value": 3 } } }, "result": { "@type": "ArithmeticValue", "variable": "result2" } } ] } } }Expected behavior
[ { "result1": { "@type": "xsd:decimal", "@value": 6 }, "result2": { "@type": "xsd:decimal", "@value": 18 } } ]Screenshots
...
Info (please complete the following information):
terminusdb/terminusdb-server:v11.1.14Additional context
Can't use
times()and all of other math WOQL methods as described in the documentation with error:SERVER ERROR: The query you have sent has no viable mode. Some variables can not be bound under any reordering.#2076SYNTAX ERROR: WOQL.limit(...).evaluate is not a function terminusdb-client-js#317
The text was updated successfully, but these errors were encountered: