Merge pull request Baseflow#351 from Baseflow/feature/flutter_lint

move to flutter_lint

Author: renefloor

flutter_cache_manager/analysis_options.yaml

@@ -1,91 +1 @@
-include: package:pedantic/analysis_options.1.8.0.yaml
-
-analyzer:
-  strong-mode:
-    implicit-casts: false
-    # implicit-dynamic: false
-  errors:
-    unused_import: warning
-    unused_local_variable: warning
-    dead_code: warning
-    invalid_override_of_non_virtual_member: error
-
-linter:
-  rules:
-    - always_declare_return_types
-    - annotate_overrides
-    - avoid_empty_else
-    - avoid_function_literals_in_foreach_calls
-    - avoid_init_to_null
-    - avoid_void_async
-    - await_only_futures
-    # - avoid_implementing_value_types
-    - avoid_null_checks_in_equality_operators
-    - avoid_renaming_method_parameters
-    - avoid_return_types_on_setters
-    - avoid_returning_null
-    - avoid_returning_null_for_void
-    - avoid_types_as_parameter_names
-    - avoid_relative_lib_imports
-    - avoid_unused_constructor_parameters
-    - camel_case_types
-    - cancel_subscriptions
-    #- cascade_invocations
-    #- comment_references
-    #- constant_identifier_names
-    - control_flow_in_finally
-    - directives_ordering
-    - empty_catches
-    - empty_constructor_bodies
-    - empty_statements
-    - hash_and_equals
-    #- implementation_imports
-    - invariant_booleans
-    - iterable_contains_unrelated_type
-    - library_names
-    - library_prefixes
-    - list_remove_unrelated_type
-    - no_adjacent_strings_in_list
-    - no_duplicate_case_values
-    - non_constant_identifier_names
-    - omit_local_variable_types
-    #- only_throw_errors
-    - overridden_fields
-    - package_api_docs
-    - package_names
-    - package_prefixed_library_names
-    - prefer_adjacent_string_concatenation
-    - prefer_collection_literals
-    - prefer_conditional_assignment
-    - prefer_const_constructors
-    - prefer_contains
-    - prefer_equal_for_default_values
-    - prefer_final_fields
-    - prefer_initializing_formals
-    #- prefer_int_literals
-    #- prefer_interpolation_to_compose_strings
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - prefer_single_quotes
-    - prefer_typing_uninitialized_variables
-    - recursive_getters
-    - slash_for_doc_comments
-    - sort_pub_dependencies
-    - test_types_in_equals
-    - throw_in_finally
-    - type_init_formals
-    - unawaited_futures
-    - unnecessary_await_in_return
-    - unnecessary_brace_in_string_interps
-    - unnecessary_getters_setters
-    - unnecessary_lambdas
-    - unnecessary_null_aware_assignments
-    - unnecessary_statements
-    - unnecessary_this
-    - unrelated_type_equality_checks
-    - use_rethrow_when_possible
-    - valid_regexps
-    # Additional Dart 2.3 lints
-    - prefer_spread_collections
-    - prefer_if_elements_to_conditional_expressions
-    - prefer_for_elements_to_map_fromIterable
+include: package:flutter_lints/flutter.yaml

flutter_cache_manager/example/analysis_options.yaml

@@ -1,29 +1 @@
-# This file configures the analyzer, which statically analyzes Dart code to
-# check for errors, warnings, and lints.
-#
-# The issues identified by the analyzer are surfaced in the UI of Dart-enabled
-# IDEs (https://dart.dev/tools#ides-and-editors). The analyzer can also be
-# invoked from the command line by running `flutter analyze`.
-
-# The following line activates a set of recommended lints for Flutter apps,
-# packages, and plugins designed to encourage good coding practices.
-include: package:flutter_lints/flutter.yaml
-
-linter:
-  # The lint rules applied to this project can be customized in the
-  # section below to disable rules from the `package:flutter_lints/flutter.yaml`
-  # included above or to enable additional rules. A list of all available lints
-  # and their documentation is published at
-  # https://dart-lang.github.io/linter/lints/index.html.
-  #
-  # Instead of disabling a lint rule for the entire project in the
-  # section below, it can also be suppressed for a single line of code
-  # or a specific dart file by using the `// ignore: name_of_lint` and
-  # `// ignore_for_file: name_of_lint` syntax on the line or in the file
-  # producing the lint.
-  rules:
-    # avoid_print: false  # Uncomment to disable the `avoid_print` rule
-    # prefer_single_quotes: true  # Uncomment to enable the `prefer_single_quotes` rule
-
-# Additional information about this file can be found at
-# https://dart.dev/guides/language/analysis-options
+include: package:flutter_lints/flutter.yaml

flutter_cache_manager/example/ios/Flutter/AppFrameworkInfo.plist

@@ -21,6 +21,6 @@
   <key>CFBundleVersion</key>
   <string>1.0</string>
   <key>MinimumOSVersion</key>
-  <string>8.0</string>
+  <string>9.0</string>
 </dict>
 </plist>

flutter_cache_manager/example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata

@@ -2,6 +2,8 @@
 //  Generated file. Do not edit.
 //
 
+// clang-format off
+
 #include "generated_plugin_registrant.h"
 
 #include <url_launcher_linux/url_launcher_plugin.h>

flutter_cache_manager/example/linux/flutter/generated_plugin_registrant.cc

@@ -2,6 +2,8 @@
 //  Generated file. Do not edit.
 //
 
+// clang-format off
+
 #ifndef GENERATED_PLUGIN_REGISTRANT_
 #define GENERATED_PLUGIN_REGISTRANT_
 

flutter_cache_manager/example/linux/flutter/generated_plugin_registrant.h

@@ -12,7 +12,6 @@ import 'package:flutter_cache_manager/src/result/file_info.dart';
 import 'package:flutter_cache_manager/src/result/file_response.dart';
 import 'package:flutter_cache_manager/src/storage/cache_object.dart';
 import 'package:flutter_cache_manager/src/web/web_helper.dart';
-import 'package:pedantic/pedantic.dart';
 import 'package:uuid/uuid.dart';
 
 import 'config/config.dart';

flutter_cache_manager/lib/src/cache_manager.dart

@@ -2,7 +2,6 @@ import 'dart:async';
 
 import 'package:flutter_cache_manager/src/config/config.dart';
 import 'package:flutter_cache_manager/src/storage/file_system/file_system.dart';
-import 'package:pedantic/pedantic.dart';
 
 import '../flutter_cache_manager.dart';
 import 'logger.dart';
@@ -86,7 +85,7 @@ class CacheStore {
           _memCache[key] = cacheObject;
         }
         completer.complete(cacheObject);
-        unawaited(_futureCache.remove(key));
+        _futureCache.remove(key);
       }));
       _futureCache[key] = completer.future;
     }
@@ -183,7 +182,7 @@ class CacheStore {
       _memCache.remove(cacheObject.key);
     }
     if (_futureCache.containsKey(cacheObject.key)) {
-      unawaited(_futureCache.remove(cacheObject.key));
+      _futureCache.remove(cacheObject.key);
     }
     final file = await fileSystem.createFile(cacheObject.relativePath);
     if (await file.exists()) {

flutter_cache_manager/lib/src/cache_store.dart

@@ -8,7 +8,7 @@ import 'package:http/http.dart' as http;
 ///Released under MIT License.
 
 /// Deprecated FileFetcher function
-typedef Future<FileFetcherResponse> FileFetcher(String url,
+typedef FileFetcher = Future<FileFetcherResponse> Function(String url,
     {Map<String, String>? headers});
 
 abstract class FileFetcherResponse {

flutter_cache_manager/lib/src/compat/file_fetcher.dart

@@ -17,6 +17,7 @@ class CacheLogger {
   /// Function to log a message on a certain loglevel
   void log(String message, CacheManagerLogLevel level) {
     if (CacheManager.logLevel.index >= level.index) {
+      // ignore: avoid_print
       print(message);
     }
   }