Skip to content

Commit 757e505

Browse files
authored
Merge pull request Baseflow#342 from ifitu/fix-race-download-access
Fix race condition of expired cache files
2 parents 30de944 + 2e9604a commit 757e505

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

flutter_cache_manager/lib/src/cache_manager.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,7 @@ class CacheManager implements BaseCacheManager {
7878
}) async {
7979
key ??= url;
8080
final cacheFile = await getFileFromCache(key);
81-
if (cacheFile != null) {
82-
if (cacheFile.validTill.isBefore(DateTime.now())) {
83-
unawaited(downloadFile(url, key: key, authHeaders: headers));
84-
}
81+
if (cacheFile != null && cacheFile.validTill.isAfter(DateTime.now())) {
8582
return cacheFile.file;
8683
}
8784
return (await downloadFile(url, key: key, authHeaders: headers)).file;

0 commit comments

Comments
 (0)