Skip to content

Commit 7993605

Browse files
authored
Remove test for Ubuntu 18.04 and leave only Ubuntu 20.04 (#1223)
Currently we test build instructions for both Ubuntu 18.04 and Ubuntu 20.04. However they are pretty much the same other than this is one more test that may fail when GitHub Action is not too reliable (see https://github.com/tensorflow/io/runs/1532063166) Since Ubuntu 20.04 is becomming more widely adopted than 18.04 now, for that reason I think it makes sense to remove the Ubuntu 18.04 test and leave only Ubuntu 20.04 test. This can avoid some intermittent test failures. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
1 parent 8543c17 commit 7993605

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,6 @@ jobs:
5959
bash -x -e source.sh
6060
python3 -c 'import tensorflow as tf; print(tf.version.VERSION)'
6161
62-
ubuntu-1804:
63-
name: Ubuntu 18.04
64-
runs-on: ubuntu-latest
65-
steps:
66-
- uses: actions/checkout@v2
67-
- run: |
68-
set -x -e
69-
bash -x -e .github/workflows/build.space.sh
70-
python3 .github/workflows/build.instruction.py README.md "##### Ubuntu 18.04/20.04" > source.sh
71-
cat source.sh
72-
docker run -i --rm -v $PWD:/v -w /v --net=host ubuntu:18.04 \
73-
bash -x -e source.sh
74-
7562
ubuntu-2004:
7663
name: Ubuntu 20.04
7764
runs-on: ubuntu-latest
@@ -80,7 +67,7 @@ jobs:
8067
- run: |
8168
set -x -e
8269
bash -x -e .github/workflows/build.space.sh
83-
python3 .github/workflows/build.instruction.py README.md "##### Ubuntu 18.04/20.04" > source.sh
70+
python3 .github/workflows/build.instruction.py README.md "##### Ubuntu 20.04" > source.sh
8471
cat source.sh
8572
docker run -i --rm -v $PWD:/v -w /v --net=host ubuntu:20.04 \
8673
bash -x -e source.sh

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,10 @@ Development of tensorflow-io on Linux is similar to macOS. The required packages
243243
are gcc, g++, git, bazel, and python 3. Newer versions of gcc or python, other than the default system installed
244244
versions might be required though.
245245

246-
##### Ubuntu 18.04/20.04
246+
##### Ubuntu 20.04
247247

248-
Ubuntu 18.04/20.04 requires gcc/g++, git, and python 3. The following will install dependencies and build
249-
the shared libraries on Ubuntu 18.04/20.04:
248+
Ubuntu 20.04 requires gcc/g++, git, and python 3. The following will install dependencies and build
249+
the shared libraries on Ubuntu 20.04:
250250
```sh
251251
#!/usr/bin/env bash
252252

0 commit comments

Comments
 (0)