Skip to content

Commit 9b98adb

Browse files
pierrot0copybara-github
authored andcommitted
remove csiphash dependency, as it is causing tests on py3 tf13 to crash. (Issue #737)
PiperOrigin-RevId: 256531213
1 parent 3845b54 commit 9b98adb

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

setup.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858

5959
TESTS_REQUIRE = [
6060
'apache-beam',
61-
'csiphash',
61+
# 'csiphash', # https://github.com/tensorflow/datasets/issues/737
6262
'jupyter',
6363
'pytest',
6464
]
@@ -123,7 +123,8 @@
123123

124124
EXTRAS_REQUIRE = {
125125
'apache-beam': ['apache-beam'],
126-
'siphash': ['csiphash'],
126+
# https://github.com/tensorflow/datasets/issues/737
127+
# 'siphash': ['csiphash'],
127128
'tensorflow': ['tensorflow>=1.13.0'],
128129
'tensorflow_gpu': ['tensorflow-gpu>=1.13.0'],
129130
'tests': TESTS_REQUIRE + all_dataset_extras,

tensorflow_datasets/core/hashing_test.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,17 @@ def test_ints(self):
9191
ints = list(range(100))
9292
hashing._CSIPHASH_AVAILABLE = False
9393
self._assert_hashes(ints, EXPECTED_INT_HASHES)
94-
hashing._CSIPHASH_AVAILABLE = True
95-
self._assert_hashes(ints, EXPECTED_INT_HASHES)
94+
# https://github.com/tensorflow/datasets/issues/737
95+
# hashing._CSIPHASH_AVAILABLE = True
96+
# self._assert_hashes(ints, EXPECTED_INT_HASHES)
9697

9798
def test_ascii(self):
9899
letters = string.ascii_lowercase + string.ascii_uppercase
99100
hashing._CSIPHASH_AVAILABLE = False
100101
self._assert_hashes(letters, EXPECTED_ASCII_HASHES)
101-
hashing._CSIPHASH_AVAILABLE = True
102-
self._assert_hashes(letters, EXPECTED_ASCII_HASHES)
102+
# https://github.com/tensorflow/datasets/issues/737
103+
# hashing._CSIPHASH_AVAILABLE = True
104+
# self._assert_hashes(letters, EXPECTED_ASCII_HASHES)
103105

104106

105107
if __name__ == '__main__':

0 commit comments

Comments
 (0)