Skip to content

Commit 14cf841

Browse files
Pantanilumtis
andauthored
ci: ignore some files for test coverage (#284)
* ignore some files for test coverage * add more files without test * remove genesis.go from ignore and increase cli package coverage * Update GetParams method comment Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
1 parent 70f4c1c commit 14cf841

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

.codecov.yml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ coverage:
1515
- modules
1616
client:
1717
if_ci_failed: error
18-
target: 35%
18+
target: 70%
1919
flags:
2020
- client
2121

@@ -29,21 +29,32 @@ flags:
2929
carryforward: true
3030
paths:
3131
- "x/"
32-
- "!x/**/client/"
32+
- "!x/**/client/**/*"
3333
client:
3434
carryforward: true
3535
paths:
36-
- "x/**/client/"
36+
- "x/**/client/**/*"
3737

3838
ignore:
39+
- "x/**/client/cli/query.go"
40+
- "x/**/client/cli/query_params.go"
41+
- "x/**/client/cli/tx.go"
42+
- "x/**/client/cli/tx_*.go"
43+
- "x/**/keeper/keeper.go"
44+
- "x/**/keeper/msg_server.go"
45+
- "x/**/keeper/grpc_query_params.go"
3946
- "x/**/types/codec.go"
4047
- "x/**/types/errors.go"
4148
- "x/**/types/keys.go"
49+
- "x/**/types/key_*.go"
50+
- "x/**/types/types.go"
51+
- "x/**/module.go"
52+
- "x/**/handler.go"
4253
- "*.proto"
4354
- "*.md"
4455
- "*.yml"
56+
- "*.yaml"
4557
- "*.pb.go"
46-
- "x/**/types/key_*.go"
4758
- ".github/"
4859
- "app/"
4960
- "cmd/"
@@ -53,4 +64,5 @@ ignore:
5364
- "scripts/"
5465
- "tests/"
5566
- "testutil/"
67+
- "dart/"
5668
- "vue/"

x/launch/keeper/params.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@ func (k Keeper) MaxLaunchTime(ctx sdk.Context) (res uint64) {
1717
return
1818
}
1919

20-
// Get all parameteras as types.Params
20+
// GetParams get all parameters as types.Params
2121
func (k Keeper) GetParams(ctx sdk.Context) types.Params {
2222
return types.NewParams(
2323
k.MinLaunchTime(ctx),
2424
k.MaxLaunchTime(ctx),
2525
)
2626
}
2727

28-
// set the params
28+
// SetParams set the params
2929
func (k Keeper) SetParams(ctx sdk.Context, params types.Params) {
3030
k.paramstore.SetParamSet(ctx, &params)
3131
}

x/launch/types/params.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var (
2121

2222
var _ paramtypes.ParamSet = (*Params)(nil)
2323

24-
// ParamTable for launch module
24+
// ParamKeyTable the param key table for launch module
2525
func ParamKeyTable() paramtypes.KeyTable {
2626
return paramtypes.NewKeyTable().RegisterParamSet(&Params{})
2727
}
@@ -42,7 +42,7 @@ func DefaultParams() Params {
4242
)
4343
}
4444

45-
// Implements params.ParamSet
45+
// ParamSetPairs get the params.ParamSet
4646
func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
4747
return paramtypes.ParamSetPairs{
4848
paramtypes.NewParamSetPair(KeyMinLaunchTime, &p.MinLaunchTime, validateLaunchTime),

0 commit comments

Comments
 (0)