You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Temporal SDK silently ignores the error when the upstream exporter fails to export the spans. I ran into a issue that the RunWorkflow span is not exported when the upstream gRPC otel exporter was misconfigured (concurrentLimit was set to 1). The problem is otel exporter returns the error through the callback function while temporal sdk just ignores it which makes it harder to debug.
Add an optional callback parameter to the makeWorkflowExporter, and just pass it to the upstream exporter as its callback. This is the easiest solution. User will at least have a way to know about the error. We can also have a default implementation for it. Take SimpleSpanProcessor as an example, the default can just be globalErrorHandler.
Additional context
It will be an API change, but shouldn't be a breaking change, since the new callback parameter will be optional.
I can help to add this if you think this is a good approach.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Temporal SDK silently ignores the error when the upstream exporter fails to export the spans. I ran into a issue that the
RunWorkflow
span is not exported when the upstream gRPC otel exporter was misconfigured (concurrentLimit
was set to 1). The problem is otel exporter returns the error through the callback function while temporal sdk just ignores it which makes it harder to debug.sdk-typescript/packages/interceptors-opentelemetry/src/worker/index.ts
Line 86 in 5ff22f0
https://github.com/open-telemetry/opentelemetry-js/blob/6f753cca7e48466d8dad1ddf372f0e6caa60c256/experimental/packages/otlp-exporter-base/src/otlp-export-delegate.ts#L62
Describe the solution you'd like
Add an optional callback parameter to the
makeWorkflowExporter
, and just pass it to the upstream exporter as its callback. This is the easiest solution. User will at least have a way to know about the error. We can also have a default implementation for it. TakeSimpleSpanProcessor
as an example, the default can just beglobalErrorHandler
.Additional context
It will be an API change, but shouldn't be a breaking change, since the new callback parameter will be optional.
I can help to add this if you think this is a good approach.
The text was updated successfully, but these errors were encountered: