Skip to content

[Feature Request] Otel exporter error handling #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cirias opened this issue Apr 27, 2025 · 0 comments
Open

[Feature Request] Otel exporter error handling #1696

cirias opened this issue Apr 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cirias
Copy link

cirias commented Apr 27, 2025

Is your feature request related to a problem? Please describe.

Temporal SDK silently ignores the error when the upstream exporter fails to export the spans. I ran into a issue that the RunWorkflow span is not exported when the upstream gRPC otel exporter was misconfigured (concurrentLimit was set to 1). The problem is otel exporter returns the error through the callback function while temporal sdk just ignores it which makes it harder to debug.

Describe the solution you'd like

Add an optional callback parameter to the makeWorkflowExporter, and just pass it to the upstream exporter as its callback. This is the easiest solution. User will at least have a way to know about the error. We can also have a default implementation for it. Take SimpleSpanProcessor as an example, the default can just be globalErrorHandler.

Additional context

It will be an API change, but shouldn't be a breaking change, since the new callback parameter will be optional.

I can help to add this if you think this is a good approach.

@cirias cirias added the enhancement New feature or request label Apr 27, 2025
@cirias cirias changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] Add callback to otel exporter Apr 27, 2025
@cirias cirias changed the title [Feature Request] Add callback to otel exporter [Feature Request] Otel exporter error handling Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant