Skip to content

Commit ed7f61a

Browse files
authored
chore: Remove internal-* packages (#881)
1 parent 6a91390 commit ed7f61a

File tree

87 files changed

+1585
-1613
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+1585
-1613
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ Breaking changes marked with a :boom:
255255
- Simplify DocBreadcrumbs so we don't need the swizzle warning comment ([#715](https://github.com/temporalio/sdk-typescript/pull/715))
256256
- Add missing deps ([#733](https://github.com/temporalio/sdk-typescript/pull/733))
257257

258-
- `@opentelemetry/api` was missing from `@temporalio/internal-non-workflow-common`
258+
- `@opentelemetry/api` was missing from `@temporalio/common/lib/internal-non-workflow`
259259

260260
- Re-export from internal-workflow-common ([#736](https://github.com/temporalio/sdk-typescript/pull/736))
261261
- [`activity`] Set Info.isLocal correctly ([#714](https://github.com/temporalio/sdk-typescript/pull/714))
@@ -860,7 +860,7 @@ Breaking changes marked with a :boom:
860860

861861
- :boom: Custom and protobuf data converters ([#477](https://github.com/temporalio/sdk-typescript/pull/477))
862862

863-
BREAKING CHANGE: [`DataConverter`](https://typescript.temporal.io/api/interfaces/worker.DataConverter) interface has changed, and some things that were exported from `common` no longer are. If it's no longer exported (see [list of exports](https://typescript.temporal.io/api/namespaces/common)), try importing from `@temporalio/activity|client|worker|workflow`. If you're unable to find it, open an issue for us to fix it, and in the meantime import from [`internal-workflow-common`](https://github.com/temporalio/sdk-typescript/tree/main/packages/internal-workflow-common) or [`internal-non-workflow-common`](https://github.com/temporalio/sdk-typescript/tree/main/packages/internal-non-workflow-common).
863+
BREAKING CHANGE: [`DataConverter`](https://typescript.temporal.io/api/interfaces/worker.DataConverter) interface has changed, and some things that were exported from `common` no longer are. If it's no longer exported (see [list of exports](https://typescript.temporal.io/api/namespaces/common)), try importing from `@temporalio/activity|client|worker|workflow`. If you're unable to find it, open an issue for us to fix it, and in the meantime import from [`internal-workflow-common`](https://github.com/temporalio/sdk-typescript/tree/main/packages/common/lib/internal-workflow) or [`internal-non-workflow-common`](https://github.com/temporalio/sdk-typescript/tree/main/packages/common/lib/internal-non-workflow).
864864

865865
- Adds custom data converter feature and changes the DataConverter API. Design doc: https://github.com/temporalio/sdk-typescript/tree/main/docs/data-converter.md#decision
866866

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ npm dist-tag rm @temporalio/testing next
228228
npm dist-tag rm @temporalio/common next
229229
npm dist-tag rm @temporalio/proto next
230230
npm dist-tag rm @temporalio/interceptors-opentelemetry next
231-
npm dist-tag rm @temporalio/internal-workflow-common next
232-
npm dist-tag rm @temporalio/internal-non-workflow-common next
231+
npm dist-tag rm @temporalio/common/lib/internal-workflow next
232+
npm dist-tag rm @temporalio/common/lib/internal-non-workflow next
233233
npm dist-tag rm @temporalio/create next
234234
npm dist-tag rm temporalio next
235235
```

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ This monorepo contains the following packages:
3737
| [`packages/common/`](packages/common/) | [`@temporalio/common`](https://www.npmjs.com/package/@temporalio/common) |
3838
| [`packages/proto/`](packages/proto/) | [`@temporalio/proto`](https://www.npmjs.com/package/@temporalio/proto) |
3939
| [`packages/interceptors-opentelemetry/`](packages/interceptors-opentelemetry/) | [`@temporalio/interceptors-opentelemetry`](https://www.npmjs.com/package/@temporalio/interceptors-opentelemetry) |
40-
| [`packages/internal-workflow-common/`](packages/internal-workflow-common/) | [`@temporalio/internal-workflow-common`](https://www.npmjs.com/package/@temporalio/internal-workflow-common) |
41-
| [`packages/internal-non-workflow-common/`](packages/internal-non-workflow-common/) | [`@temporalio/internal-non-workflow-common`](https://www.npmjs.com/package/@temporalio/internal-non-workflow-common) |
40+
| [`packages/common/lib/internal-workflow/`](packages/common/lib/internal-workflow/) | [`@temporalio/common/lib/internal-workflow`](https://www.npmjs.com/package/@temporalio/common/lib/internal-workflow) |
41+
| [`packages/common/lib/internal-non-workflow/`](packages/common/lib/internal-non-workflow/) | [`@temporalio/common/lib/internal-non-workflow`](https://www.npmjs.com/package/@temporalio/common/lib/internal-non-workflow) |
4242
| [`packages/meta/`](packages/meta/) | [`temporalio`](https://www.npmjs.com/package/@temporalio/meta) (deprecated) |
4343
| [`packages/test/`](packages/test/) | SDK internal tests |
4444
| [`packages/create-project/`](packages/create-project/) | [`@temporalio/create`](https://www.npmjs.com/package/@temporalio/create-project) |

0 commit comments

Comments
 (0)