fix: update create-package to recursively find package.json and tsconfig.json files during sample creation (#1089)

Co-authored-by: James Watkins-Harvey <mjameswh@gmail.com>

Author: jhubbardsf

package-lock.json

@@ -24,7 +24,7 @@
     "chalk-template": "^0.4.0",
     "commander": "^9.3.0",
     "dedent": "^0.7.0",
-    "glob": "^8.0.3",
+    "glob": "^9.3.2",
     "got": "^12.1.0",
     "prompts": "^2.4.2",
     "tar": "^6.1.13",

packages/create-project/package.json

@@ -1,9 +1,8 @@
 // Modified from: https://github.com/vercel/next.js/blob/2425f4703c4c6164cecfdb6aa8f80046213f0cc6/packages/create-next-app/helpers/install.ts
 import { readFile, writeFile } from 'node:fs/promises';
-
+import { glob } from 'glob';
 import { spawn } from './subprocess.js';
 import { isUrlOk } from './samples.js';
-import { getErrorCode } from './get-error-code.js';
 
 interface InstallArgs {
   root: string;
@@ -38,25 +37,14 @@ export async function updateNodeVersion({ root }: InstallArgs): Promise<void> {
 
   if (currentNodeVersion >= minimumValidVersion && currentNodeVersion !== versionAlreadyInPackageJson) {
     const packageName = `@tsconfig/node${currentNodeVersion}`;
-    const fileName = `${root}/package.json`;
 
     const packageExists = await isUrlOk(`https://registry.npmjs.org/${packageName}`);
     if (packageExists) {
-      let fileString = (await readFile(fileName)).toString();
-      await writeFile(fileName, fileString.replace(`@tsconfig/node${versionAlreadyInPackageJson}`, packageName));
-
-      const tsconfigJson = `${root}/tsconfig.json`;
-
-      try {
-        fileString = (await readFile(tsconfigJson)).toString();
-        await writeFile(tsconfigJson, fileString.replace(`@tsconfig/node${versionAlreadyInPackageJson}`, packageName));
-      } catch (error) {
-        const code = getErrorCode(error);
+      const fileNames = await glob([`${root}/**/package.json`, `${root}/**/tsconfig.json`]);
 
-        // If the file doesn't exist, that's fine
-        if (code !== 'ENOENT') {
-          throw error;
-        }
+      for (const fileName of fileNames) {
+        const fileString = (await readFile(fileName)).toString();
+        await writeFile(fileName, fileString.replace(`@tsconfig/node${versionAlreadyInPackageJson}`, packageName));
       }
     }
 

packages/create-project/src/helpers/install.ts

@@ -1,9 +1,9 @@
 import path from 'node:path';
 import { readFile, writeFile } from 'node:fs/promises';
-import glob from 'glob'; // eslint-disable-line import/no-named-as-default
+import { sync } from 'glob';
 
 export async function stripSnipComments(root: string): Promise<void> {
-  const files = glob.sync('**/*.ts', { cwd: root });
+  const files = sync('**/*.ts', { cwd: root });
   await Promise.all(
     files.map(async (file) => {
       const filePath = path.join(root, file);

packages/create-project/src/helpers/strip-snip-comments.ts

@@ -2,7 +2,6 @@
 import path from 'node:path';
 import v8 from 'node:v8';
 import { readFileSync } from 'node:fs';
-import * as grpc from '@grpc/grpc-js';
 import asyncRetry from 'async-retry';
 import anyTest, { Implementation, TestFn } from 'ava';
 import dedent from 'dedent';