fix(workflow): Don't propagate cancellation from non-cancellable scopes to children (backport from #1429) (#1466)

Author: mjameswh

packages/test/src/helpers-integration.ts

@@ -98,18 +98,18 @@ export interface Helpers {
   assertWorkflowFailedError(p: Promise<any>, causeConstructor: ErrorConstructor, message?: string): Promise<void>;
 }
 
-export function helpers(t: ExecutionContext<Context>): Helpers {
+export function helpers(t: ExecutionContext<Context>, testEnv: TestWorkflowEnvironment = t.context.env): Helpers {
   const taskQueue = t.title.replace(/ /g, '_');
 
   return {
     taskQueue,
     async createWorker(opts?: Partial<WorkerOptions>): Promise<Worker> {
       return await Worker.create({
-        connection: t.context.env.nativeConnection,
+        connection: testEnv.nativeConnection,
         workflowBundle: t.context.workflowBundle,
         taskQueue,
         interceptors: {
-          activity: [() => ({ inbound: new ConnectionInjectorInterceptor(t.context.env.connection) })],
+          activity: [() => ({ inbound: new ConnectionInjectorInterceptor(testEnv.connection) })],
         },
         showStackTraceSources: true,
         ...opts,
@@ -119,7 +119,7 @@ export function helpers(t: ExecutionContext<Context>): Helpers {
       fn: workflow.Workflow,
       opts?: Omit<WorkflowStartOptions, 'taskQueue' | 'workflowId'>
     ): Promise<any> {
-      return await t.context.env.client.workflow.execute(fn, {
+      return await testEnv.client.workflow.execute(fn, {
         taskQueue,
         workflowId: randomUUID(),
         ...opts,
@@ -129,7 +129,7 @@ export function helpers(t: ExecutionContext<Context>): Helpers {
       fn: workflow.Workflow,
       opts?: Omit<WorkflowStartOptions, 'taskQueue' | 'workflowId'>
     ): Promise<WorkflowHandle<workflow.Workflow>> {
-      return await t.context.env.client.workflow.start(fn, {
+      return await testEnv.client.workflow.start(fn, {
         taskQueue,
         workflowId: randomUUID(),
         ...opts,

packages/test/src/helpers.ts

@@ -72,7 +72,7 @@ export function cleanStackTrace(ostack: string): string {
   return normalizedStack ? `${firstLine}\n${normalizedStack}` : firstLine;
 }
 
-function noopTest() {
+function noopTest(): void {
   // eslint: this function body is empty and it's okay.
 }
 

packages/test/src/mock-internal-flags.ts

@@ -0,0 +1,28 @@
+import { getActivator } from '@temporalio/workflow/lib/global-attributes';
+import { SdkFlag } from '@temporalio/workflow/lib/flags';
+
+const defaultValueOverrides = new Map<number, boolean>();
+
+let mockInstalled = false;
+
+function maybeInstallMock() {
+  if (mockInstalled) return;
+  const activator = getActivator();
+  const originalHasFlag = activator.hasFlag.bind(activator);
+  activator.hasFlag = (flag) => {
+    const overridenDefaultValue = defaultValueOverrides.get(flag.id);
+    if (overridenDefaultValue !== undefined) {
+      flag = { id: flag.id, default: overridenDefaultValue };
+    }
+    return originalHasFlag(flag);
+  };
+  mockInstalled = true;
+}
+
+// Override the default value of an SDK flag. That is, assuming a workflow execution is not in
+// replay mode and that `f` has not already been recorded, then `hasFlag(f)` will return
+// `defaultValue`, and record the flag to history if `defaultValue` is `true`.
+export function overrideSdkInternalFlag(flag: SdkFlag, defaultValue: boolean): void {
+  maybeInstallMock();
+  defaultValueOverrides.set(flag.id, defaultValue);
+}