Skip to content

Commit be83b0d

Browse files
committed
Upgrade core, TODO fix protos and versioning behavior
1 parent 0490e7b commit be83b0d

File tree

5 files changed

+64
-39
lines changed

5 files changed

+64
-39
lines changed

packages/core-bridge/Cargo.lock

Lines changed: 59 additions & 30 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core-bridge/sdk-core

Submodule sdk-core updated 105 files

packages/core-bridge/src/worker.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -476,8 +476,6 @@ mod config {
476476
#[derive(TryFromJs)]
477477
pub struct BridgeWorkerOptions {
478478
identity: String,
479-
build_id: String,
480-
use_versioning: bool,
481479
task_queue: String,
482480
namespace: String,
483481
tuner: WorkerTuner,
@@ -513,8 +511,6 @@ mod config {
513511
let mut builder = WorkerConfigBuilder::default();
514512
builder
515513
.client_identity_override(Some(self.identity))
516-
.worker_build_id(self.build_id)
517-
.use_worker_versioning(self.use_versioning)
518514
.task_queue(self.task_queue)
519515
.namespace(self.namespace)
520516
.tuner(self.tuner.into_core_config()?)
@@ -698,7 +694,7 @@ mod custom_slot_supplier {
698694
slot_type: SK::kind().into(),
699695
task_queue: ctx.task_queue().to_string(),
700696
worker_identity: ctx.worker_identity().to_string(),
701-
worker_build_id: ctx.worker_build_id().to_string(),
697+
worker_build_id: "".to_owned(),
702698
is_sticky: ctx.is_sticky(),
703699
};
704700

@@ -739,7 +735,7 @@ mod custom_slot_supplier {
739735
slot_type: SK::kind().into(),
740736
task_queue: ctx.task_queue().to_string(),
741737
worker_identity: ctx.worker_identity().to_string(),
742-
worker_build_id: ctx.worker_build_id().to_string(),
738+
worker_build_id: "".to_owned(),
743739
is_sticky: ctx.is_sticky(),
744740
};
745741

packages/worker/src/worker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1421,7 +1421,7 @@ export class Worker {
14211421
// A zero value means that it was not set by the server
14221422
historySize: activation.historySizeBytes.toNumber(),
14231423
continueAsNewSuggested: activation.continueAsNewSuggested,
1424-
currentBuildId: activation.buildIdForCurrentTask,
1424+
// currentBuildId: activation.buildIdForCurrentTask,
14251425
unsafe: {
14261426
now: () => Date.now(), // re-set in initRuntime
14271427
isReplaying: activation.isReplaying,

packages/worker/src/workflow/vm-shared.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ export abstract class BaseVMWorkflow implements Workflow {
348348
// historySize === 0 means WFT was generated by pre-1.20.0 server, and the history size is unknown
349349
historySize: activation.historySizeBytes?.toNumber() ?? 0,
350350
continueAsNewSuggested: activation.continueAsNewSuggested ?? false,
351-
currentBuildId: activation.buildIdForCurrentTask ?? undefined,
351+
// currentBuildId: activation.buildIdForCurrentTask ?? undefined,
352352
unsafe: {
353353
...info.unsafe,
354354
isReplaying: activation.isReplaying ?? false,

0 commit comments

Comments
 (0)