Skip to content

Commit b954566

Browse files
authored
Update Core, CHANGELOG, and publish instructions (#1099)
1 parent d943b86 commit b954566

File tree

6 files changed

+43
-13
lines changed

6 files changed

+43
-13
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@ All notable changes to this project will be documented in this file.
44

55
Breaking changes marked with a :boom:
66

7+
## [1.7.2] - 2023-04-14
8+
9+
### Bug Fixes
10+
11+
- [`core`] Fix scenario where server sends page token pointing to empty page [#533](https://github.com/temporalio/sdk-core/pull/533)
12+
- [`core`] Fix internal flags not always being written when they should be [#532](https://github.com/temporalio/sdk-core/pull/532)
13+
- [`core`] Ensure cancels get delivered after grace, even if poll stream not done [#531](https://github.com/temporalio/sdk-core/pull/531)
14+
- [`core`] Get rid of leftover warning log line [#530](https://github.com/temporalio/sdk-core/pull/530)
15+
716
## [1.7.1] - 2023-04-13
817

918
### Features

CONTRIBUTING.md

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -197,14 +197,11 @@ ls packages/core-bridge/releases/
197197

198198
npx lerna version patch --force-publish='*' # or major|minor|etc, or leave out to be prompted. either way, you get a confirmation dialog.
199199

200-
node ./scripts/tilde-deps.mjs
201-
202-
git add packages
203-
git commit -m 'Depend on ~1.5.0'
204-
git tag v1.5.0 -f
205-
git push origin v1.5.0 -f
200+
git checkout -B fix-deps
201+
node scripts/prepublish.mjs
202+
git commit -am 'Fix dependencies'
206203
npx lerna publish from-package # add `--dist-tag next` for pre-release versions
207-
git reset HEAD^ --hard
204+
git checkout -
208205
```
209206

210207
Finally:
@@ -216,8 +213,8 @@ npm deprecate temporalio@^1.0.0 "Instead of installing temporalio, we recommend
216213
- Cleanup after publishing:
217214

218215
```sh
219-
rm $HOME/Downloads/packages-*
220-
rm packages/core-bridge/releases/
216+
rm -rf $HOME/Downloads/packages-*
217+
rm -rf packages/core-bridge/releases/*
221218
```
222219

223220
- If using a custom [features](https://github.com/temporalio/features/) branch for PR integration tests, merge

packages/core-bridge/Cargo.lock

Lines changed: 21 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core-bridge/sdk-core

Submodule sdk-core updated 32 files

packages/test/src/integration-tests.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1365,14 +1365,17 @@ export function runIntegrationTests(codec?: PayloadCodec): void {
13651365
// Test the list API too while we're at it
13661366
const workflowIds = handles.map(({ workflowId }) => `'${workflowId}'`);
13671367
const histories = client.workflow.list({ query: `WorkflowId IN (${workflowIds.join(', ')})` }).intoHistories();
1368-
1369-
await Worker.runReplayHistories(
1368+
const results = Worker.runReplayHistories(
13701369
{
13711370
workflowsPath: require.resolve('./workflows'),
13721371
dataConverter: t.context.dataConverter,
13731372
},
13741373
histories
13751374
);
1375+
1376+
for await (const result of results) {
1377+
t.is(result.error, undefined);
1378+
}
13761379
t.pass();
13771380
});
13781381

scripts/prepublish.js renamed to scripts/prepublish.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ for (const dir of packages) {
1414
const packageJson = JSON.parse(await fs.readFile(packageJsonPath, 'utf8'));
1515
for (const dep of Object.keys(packageJson.dependencies)) {
1616
if (dep.startsWith('@temporalio/')) {
17-
packageJson.dependencies[dep] = `~${version}`;
17+
packageJson.dependencies[dep] = `${version}`;
1818
}
1919
}
2020
const replacedContent = JSON.stringify(packageJson, null, 2);

0 commit comments

Comments
 (0)