chore: Use import/order eslint rule (#965)

Author: lorensr

.eslintrc

@@ -44,8 +44,12 @@
     "import/no-mutable-exports": "error",
     "import/unambiguous": "error",
     "import/first": "error",
-    // TODO next PR
-    // "import/order": "error",
+    "import/order": [
+      "error",
+      {
+        "groups": ["builtin", "external", "internal", "parent", "sibling", "index"]
+      }
+    ],
     "import/newline-after-import": "error",
     "import/no-unassigned-import": "error",
     "import/no-named-default": "error"
@@ -61,6 +65,7 @@
         "alwaysTryTypes": true,
         "project": ["packages/*/tsconfig.json"]
       }
-    }
+    },
+    "import/internal-regex": "^@temporalio/"
   }
 }

.github/workflows/ci.yml

@@ -120,7 +120,7 @@ jobs:
       # eslint-import-resolver-typescript requires packages to be built
       - name: Compile all non-rust code
         run: npm run build -- --ignore @temporalio/core-bridge
-      - run: npm run lint
+      - run: npm run lint.check
       - run: npm run lint.prune
 
   # Compile native bridge code and isolate extension for Windows, Mac and Linux.

package.json

@@ -29,7 +29,8 @@
     "ci-stress": "node ./packages/test/lib/load/run-all-stress-ci-scenarios.js",
     "ci-nightly": "node ./packages/test/lib/load/run-all-nightly-scenarios.js",
     "wait-namespace": "node ./scripts/wait-on-temporal.mjs",
-    "lint": "eslint packages/*/src --ext .ts --no-error-on-unmatched-pattern && prettier --end-of-line auto --check .",
+    "lint": "eslint packages/*/src --ext .ts --no-error-on-unmatched-pattern --fix && prettier --write .",
+    "lint.check": "eslint packages/*/src --ext .ts --no-error-on-unmatched-pattern && prettier --end-of-line auto --check .",
     "lint.prune": "ts-prune --error -p tsconfig.prune.json --ignore \"used in module\" --skip \".d.ts\"",
     "format": "prettier --write .",
     "clean": "node ./scripts/clean.mjs",

packages/activity/src/index.ts

@@ -69,8 +69,8 @@
  * @module
  */
 
-import { AbortSignal } from 'abort-controller';
 import { AsyncLocalStorage } from 'async_hooks';
+import { AbortSignal } from 'abort-controller';
 import { msToNumber } from '@temporalio/common/lib/time';
 
 export {

packages/client/src/base-client.ts

@@ -1,8 +1,8 @@
+import os from 'os';
 import { DataConverter, LoadedDataConverter } from '@temporalio/common';
 import { isLoadedDataConverter, loadDataConverter } from '@temporalio/common/lib/internal-non-workflow';
 import { Connection } from './connection';
 import { ConnectionLike, Metadata } from './types';
-import os from 'os';
 
 export interface BaseClientOptions {
   /**

packages/client/src/connection.ts

@@ -1,8 +1,8 @@
+import { AsyncLocalStorage } from 'async_hooks';
 import * as grpc from '@grpc/grpc-js';
+import type { RPCImpl } from 'protobufjs';
 import { filterNullAndUndefined, normalizeTlsConfig, TLSConfig } from '@temporalio/common/lib/internal-non-workflow';
 import { msOptionalToNumber } from '@temporalio/common/lib/time';
-import { AsyncLocalStorage } from 'async_hooks';
-import type { RPCImpl } from 'protobufjs';
 import { isServerErrorResponse, ServiceError } from './errors';
 import { defaultGrpcRetryOptions, makeGrpcRetryInterceptor } from './grpc-retry';
 import pkg from './pkg';

packages/client/src/helpers.ts

@@ -6,8 +6,8 @@ import {
 } from '@temporalio/common';
 import { optionalTsToDate, tsToDate } from '@temporalio/common/lib/time';
 import { decodeMapFromPayloads } from '@temporalio/common/lib/internal-non-workflow/codec-helpers';
-import { RawWorkflowExecutionInfo, WorkflowExecutionInfo, WorkflowExecutionStatusName } from './types';
 import { temporal } from '@temporalio/proto';
+import { RawWorkflowExecutionInfo, WorkflowExecutionInfo, WorkflowExecutionStatusName } from './types';
 
 function workflowStatusCodeToName(code: temporal.api.enums.v1.WorkflowExecutionStatus): WorkflowExecutionStatusName {
   return workflowStatusCodeToNameInternal(code) ?? 'UNKNOWN';

packages/client/src/schedule-client.ts

@@ -1,14 +1,16 @@
 import { status as grpcStatus } from '@grpc/grpc-js';
+import { v4 as uuid4 } from 'uuid';
 import { mapToPayloads, searchAttributePayloadConverter } from '@temporalio/common';
 import { composeInterceptors, Headers } from '@temporalio/common/lib/interceptors';
 import {
   encodeMapToPayloads,
   decodeMapFromPayloads,
   filterNullAndUndefined,
 } from '@temporalio/common/lib/internal-non-workflow';
+import { temporal } from '@temporalio/proto';
+import { optionalDateToTs, optionalTsToDate, optionalTsToMs, tsToDate } from '@temporalio/common/lib/time';
 import { CreateScheduleInput, CreateScheduleOutput, ScheduleClientInterceptor } from './interceptors';
 import { WorkflowService } from './types';
-import { v4 as uuid4 } from 'uuid';
 import { isServerErrorResponse, ServiceError } from './errors';
 import {
   Backfill,
@@ -19,8 +21,6 @@ import {
   ScheduleOverlapPolicy,
   ScheduleUpdateOptions,
 } from './schedule-types';
-import { temporal } from '@temporalio/proto';
-import { optionalDateToTs, optionalTsToDate, optionalTsToMs, tsToDate } from '@temporalio/common/lib/time';
 import {
   compileScheduleOptions,
   compileUpdatedScheduleOptions,

packages/client/src/schedule-helpers.ts

@@ -1,3 +1,4 @@
+import Long from 'long'; // eslint-disable-line import/no-named-as-default
 import {
   compileRetryPolicy,
   decompileRetryPolicy,
@@ -14,6 +15,16 @@ import {
   encodeMapToPayloads,
   encodeToPayloads,
 } from '@temporalio/common/lib/internal-non-workflow';
+import { temporal } from '@temporalio/proto';
+import {
+  msOptionalToTs,
+  msToTs,
+  optionalDateToTs,
+  optionalTsToDate,
+  optionalTsToMs,
+  tsToDate,
+} from '@temporalio/common/lib/time';
+import { RequireAtLeastOne } from '@temporalio/common/src/type-helpers';
 import {
   CalendarSpec,
   CalendarSpecDescription,
@@ -37,18 +48,6 @@ import {
   ScheduleExecutionResult,
   ScheduleExecutionStartWorkflowActionResult,
 } from './schedule-types';
-import { temporal } from '@temporalio/proto';
-import {
-  msOptionalToTs,
-  msToTs,
-  optionalDateToTs,
-  optionalTsToDate,
-  optionalTsToMs,
-  tsToDate,
-} from '@temporalio/common/lib/time';
-import { RequireAtLeastOne } from '@temporalio/common/src/type-helpers';
-// eslint-disable-next-line import/no-named-as-default
-import Long from 'long';
 
 const [encodeSecond, decodeSecond] = makeCalendarSpecFieldCoders(
   'second',

packages/client/src/types.ts

@@ -1,6 +1,6 @@
+import type * as grpc from '@grpc/grpc-js';
 import type { SearchAttributes } from '@temporalio/common';
 import * as proto from '@temporalio/proto';
-import type * as grpc from '@grpc/grpc-js';
 import { Replace } from '@temporalio/common/lib/type-helpers';
 
 export interface WorkflowExecution {