Skip to content

Commit 4daeafe

Browse files
authored
chore: Update Core to latest (#1571)
1 parent ddcf0b3 commit 4daeafe

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

packages/client/src/async-completion-client.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { status as grpcStatus } from '@grpc/grpc-js';
22
import { ensureTemporalFailure } from '@temporalio/common';
3-
import type { temporal } from '@temporalio/proto';
43
import {
54
encodeErrorToFailure,
65
encodeToPayloads,
@@ -216,23 +215,23 @@ export class AsyncCompletionClient extends BaseClient {
216215
const payloads = await encodeToPayloads(this.dataConverter, details);
217216
let cancelRequested = false;
218217
try {
219-
let response: temporal.api.workflowservice.v1.RecordActivityTaskHeartbeatResponse;
220218
if (taskTokenOrFullActivityId instanceof Uint8Array) {
221-
response = await this.workflowService.recordActivityTaskHeartbeat({
219+
const response = await this.workflowService.recordActivityTaskHeartbeat({
222220
identity: this.options.identity,
223221
namespace: this.options.namespace,
224222
taskToken: taskTokenOrFullActivityId,
225223
details: { payloads },
226224
});
225+
cancelRequested = !!response.cancelRequested;
227226
} else {
228-
response = await this.workflowService.recordActivityTaskHeartbeatById({
227+
const response = await this.workflowService.recordActivityTaskHeartbeatById({
229228
identity: this.options.identity,
230229
namespace: this.options.namespace,
231230
...taskTokenOrFullActivityId,
232231
details: { payloads },
233232
});
233+
cancelRequested = !!response.cancelRequested;
234234
}
235-
cancelRequested = !!response.cancelRequested;
236235
} catch (err) {
237236
this.handleError(err);
238237
}

packages/core-bridge/Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/core-bridge/sdk-core

Submodule sdk-core updated 38 files

packages/core-bridge/src/runtime.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ use temporal_sdk_core::{
1414
ephemeral_server::EphemeralServer as CoreEphemeralServer,
1515
init_replay_worker, init_worker,
1616
replay::{HistoryForReplay, ReplayWorkerInput},
17-
ClientOptions, CoreRuntime, RetryClient, WorkerConfig,
17+
ClientOptions, CoreRuntime, RetryClient, TokioRuntimeBuilder, WorkerConfig,
1818
};
1919
use tokio::sync::{
2020
mpsc::{channel, unbounded_channel, Sender, UnboundedReceiver, UnboundedSender},
@@ -126,6 +126,10 @@ pub fn start_bridge_loop(
126126
tokio_builder.enable_all().thread_name("core");
127127
let telem_opts = telemetry_options.0;
128128
let meter_maker = telemetry_options.1;
129+
let tokio_builder: TokioRuntimeBuilder<Box<dyn Fn() + Send + Sync>> = TokioRuntimeBuilder {
130+
inner: tokio_builder,
131+
lang_on_thread_start: None,
132+
};
129133
let mut core_runtime =
130134
CoreRuntime::new(telem_opts, tokio_builder).expect("Failed to create CoreRuntime");
131135

0 commit comments

Comments
 (0)