chore: Update NPM dependencies (#1330)

Author: mjameswh

.eslintrc

@@ -38,8 +38,6 @@
     "import/no-relative-packages": "error",
     "import/export": "error",
     "import/no-named-as-default": "error",
-    // TODO enable and fix
-    // "import/no-deprecated": "error",
     "import/no-extraneous-dependencies": "error",
     "import/no-mutable-exports": "error",
     "import/unambiguous": "error",

.github/workflows/ci.yml

@@ -15,13 +15,13 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        reuse-v8-context: [false]
-        node: [14, 16]
+        reuse-v8-context: [true]
+        node: [14, 16, 18, 20]
         os: [ubuntu-latest, macos-latest, windows-latest]
         include:
           - os: ubuntu-latest
-            node: 16
-            reuse-v8-context: true
+            node: 20
+            reuse-v8-context: false
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -88,7 +88,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 20
       - name: Install protoc
         uses: arduino/setup-protoc@v1
         with:
@@ -120,7 +120,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v1
         with:
-          node-version: 16
+          node-version: 20
       - name: Install protoc
         uses: arduino/setup-protoc@v1
         with:
@@ -208,22 +208,22 @@ jobs:
         include:
           - os: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-            node: 16
+            node: 20
             server: local
             sample: hello-world
           - os: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-            node: 16
+            node: 20
             server: local
             sample: fetch-esm
           - os: macos-latest
             target: x86_64-apple-darwin
-            node: 16
+            node: 20
             server: cloud
             sample: hello-world-mtls
           - os: windows-latest
             target: x86_64-pc-windows-msvc
-            node: 16
+            node: 20
             server: cloud
             sample: hello-world-mtls
 

.prettierrc.json

@@ -1,4 +1,5 @@
 {
   "printWidth": 120,
-  "singleQuote": true
+  "singleQuote": true,
+  "trailingComma": "es5"
 }

CONTRIBUTING.md

@@ -50,7 +50,7 @@ See [sdk-structure.md](./docs/sdk-structure.md)
 
 ### Environment setup
 
-- Install Node 16 and [Temporal Server](https://github.com/temporalio/docker-compose#temporal-server-docker-compose-files)
+- Install Node 18 and [Temporal Server](https://github.com/temporalio/docker-compose#temporal-server-docker-compose-files)
 - Install the [Rust toolchain](https://rustup.rs/)
 - Install [Protocol Buffers](https://github.com/protocolbuffers/protobuf/releases/)
 - Clone the [sdk-typescript](https://github.com/temporalio/sdk-typescript) repo:
@@ -143,6 +143,43 @@ chore(samples): upgrade commander module
 
 The `scope` options are listed in [commitlint.config.js](https://github.com/temporalio/sdk-typescript/blob/main/commitlint.config.js).
 
+## Updating and pruning dependencies
+
+There are various tools out there to help with updating and pruning NPM dependencies. Unfortunately,
+most of these tools don't work well in older lerna-style monorepos, such as this one, and updating
+to NPM 7 workspace would break support for Node 14.x. We must therefore rely on a more manual
+approach.
+
+I personally use the following commands to find NPM packages that needs to be updated. It runs
+interactively on each package of the repo, making it easy to select and apply packages to be updated.
+
+```
+for i in ./package.json packages/*/package.json ; do
+  (
+    cd "${i%%package.json}"
+    pwd
+    npm-check-updates -i
+  )
+done
+```
+
+To identify unused dependencies, I run the following script. Note that `npm-check` may report
+false-positive. Search the code before actually deleting any dependency. Also note that runtime
+dependencies MUST be added on the actual packages that use them to ensure proper execution in PNPM
+and YARN 2+ setups.
+
+```
+for i in ./package.json packages/*/package.json ; do
+  (
+    cd "${i%%package.json}"
+    pwd
+    npm-check
+  )
+done
+```
+
+To install both tools: `npm i -g npm-check npm-check-updates`.
+
 ## Publishing
 
 First, follow the instructions in [docs/building.md](docs/building.md).