File tree Expand file tree Collapse file tree 1 file changed +9
-1
lines changed Expand file tree Collapse file tree 1 file changed +9
-1
lines changed Original file line number Diff line number Diff line change @@ -129,6 +129,14 @@ jobs:
129
129
- platform : windows-x64
130
130
runner : windows-latest
131
131
reuse-v8-context : true
132
+ # Node 22.12.0 on Windows incorrectly resolves `localhost` to `::1`, rather than both `::1` and `127.0.0.1`.
133
+ # We changed all of our internal tests to exclusively use `127.0.0.1`, but samples are still written to use
134
+ # `localhost`, which really is the proper thing to do in samples. So until this gets fixed upstream, we force
135
+ # the last known good version of Node on Windows.
136
+ # See https://github.com/nodejs/node/issues/56137 (_resolved_ already, but not yet released).
137
+ - platform : windows-x64
138
+ node : 22
139
+ node-release-override : 22.11.0
132
140
runs-on : ${{ matrix.runner }}
133
141
name : Run Integration Tests (${{ matrix.platform }}, Node ${{ matrix.node }}, Reuse V8 Context ${{ matrix.reuse-v8-context }})
134
142
defaults :
@@ -155,7 +163,7 @@ jobs:
155
163
- name : Install Node
156
164
uses : actions/setup-node@v4
157
165
with :
158
- node-version : ${{ matrix.node }}
166
+ node-version : ${{ matrix.node-release-override || matrix.node }}
159
167
160
168
# On Windows, the 'runner.temp' variable uses backslashes as path separators, but
161
169
# that may pose problems in later steps when we try to join that with subpaths;
You can’t perform that action at this time.
0 commit comments