Skip to content

Commit 4886c7d

Browse files
committed
chore: fix test fail on Windows w/ Node 22.12.0 (backport of 5ddbda14)
1 parent ff44a0e commit 4886c7d

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,14 @@ jobs:
129129
- platform: windows-x64
130130
runner: windows-latest
131131
reuse-v8-context: true
132+
# Node 22.12.0 on Windows incorrectly resolves `localhost` to `::1`, rather than both `::1` and `127.0.0.1`.
133+
# We changed all of our internal tests to exclusively use `127.0.0.1`, but samples are still written to use
134+
# `localhost`, which really is the proper thing to do in samples. So until this gets fixed upstream, we force
135+
# the last known good version of Node on Windows.
136+
# See https://github.com/nodejs/node/issues/56137 (_resolved_ already, but not yet released).
137+
- platform: windows-x64
138+
node: 22
139+
node-release-override: 22.11.0
132140
runs-on: ${{ matrix.runner }}
133141
name: Run Integration Tests (${{ matrix.platform }}, Node ${{ matrix.node }}, Reuse V8 Context ${{ matrix.reuse-v8-context }})
134142
defaults:
@@ -155,7 +163,7 @@ jobs:
155163
- name: Install Node
156164
uses: actions/setup-node@v4
157165
with:
158-
node-version: ${{ matrix.node }}
166+
node-version: ${{ matrix.node-release-override || matrix.node }}
159167

160168
# On Windows, the 'runner.temp' variable uses backslashes as path separators, but
161169
# that may pose problems in later steps when we try to join that with subpaths;

0 commit comments

Comments
 (0)