Bunch of small stuff (#891)

* Fix double import of long in generated proto TS files

* Fix bundler with default workflow interceptors

* Label grpc-retry API as experimental

* Upgrade core, add support for OTEL metric temporality

* Limit eager activity requests to 3

* Make the failure-converter code symmetric

* Fix tests

Author: bergundy

packages/client/src/grpc-retry.ts

@@ -1,6 +1,9 @@
 import { InterceptingCall, Interceptor, ListenerBuilder, RequesterBuilder, StatusObject } from '@grpc/grpc-js';
 import * as grpc from '@grpc/grpc-js';
 
+/**
+ * @experimental
+ */
 export interface GrpcRetryOptions {
   /**
    * A function which accepts the current retry attempt (starts at 1) and returns the millisecond
@@ -16,6 +19,8 @@ export interface GrpcRetryOptions {
 
 /**
  * Options for the backoff formula: `factor ^ attempt * initialIntervalMs(status) * jitter(maxJitter)`
+ *
+ * @experimental
  */
 export interface BackoffOptions {
   /**
@@ -74,6 +79,8 @@ function withDefaultBackoffOptions({
 
 /**
  * Generates the default retry behavior based on given backoff options
+ *
+ * @experimental
  */
 export function defaultGrpcRetryOptions(options: Partial<BackoffOptions> = {}): GrpcRetryOptions {
   const { maxAttempts, factor, maxJitter, initialIntervalMs, maxIntervalMs } = withDefaultBackoffOptions(options);
@@ -125,6 +132,8 @@ function defaultInitialIntervalMs({ code }: StatusObject) {
  * Returns a GRPC interceptor that will perform automatic retries for some types of failed calls
  *
  * @param retryOptions Options for the retry interceptor
+ *
+ * @experimental
  */
 export function makeGrpcRetryInterceptor(retryOptions: GrpcRetryOptions): Interceptor {
   return (options, nextCall) => {

packages/common/src/converter/failure-converter.ts

@@ -190,24 +190,26 @@ export class DefaultFailureConverter implements FailureConverter {
   }
 
   failureToError(failure: ProtoFailure): TemporalFailure {
-    const err = this.failureToErrorInner(failure);
-    err.stack = failure.stackTrace ?? '';
-    err.failure = failure;
     if (failure.encodedAttributes) {
       const attrs = this.options.payloadConverter.fromPayload<DefaultEncodedFailureAttributes>(
         failure.encodedAttributes
       );
       // Don't apply encodedAttributes unless they conform to an expected schema
       if (typeof attrs === 'object' && attrs !== null) {
         const { message, stack_trace } = attrs;
+        // Avoid mutating the argument
+        failure = { ...failure };
         if (typeof message === 'string') {
-          err.message = message;
+          failure.message = message;
         }
         if (typeof stack_trace === 'string') {
-          err.stack = stack_trace;
+          failure.stackTrace = stack_trace;
         }
       }
     }
+    const err = this.failureToErrorInner(failure);
+    err.stack = failure.stackTrace ?? '';
+    err.failure = failure;
     return err;
   }