fix: Default searchAttributes to {} and edit type (#738)

Author: lorensr

packages/internal-workflow-common/src/interfaces.ts

@@ -45,5 +45,5 @@ export type WorkflowResultType<W extends Workflow> = ReturnType<W> extends Promi
  *
  * Dates are serialized as ISO strings.
  */
-export type SearchAttributes = Record<string, SearchAttributeValue>;
+export type SearchAttributes = Record<string, SearchAttributeValue | undefined>;
 export type SearchAttributeValue = string[] | number[] | boolean[] | Date[];

packages/test/src/integration-tests.ts

@@ -678,6 +678,7 @@ export function runIntegrationTests(codec?: PayloadCodec): void {
       taskTimeoutMs: 10_000,
       runId: workflow.firstExecutionRunId,
       taskQueue: 'test',
+      searchAttributes: {},
       workflowType: 'returnWorkflowInfo',
       workflowId,
     });

packages/test/src/test-sinks.ts

@@ -99,7 +99,7 @@ if (RUN_INTEGRATION_TESTS) {
       lastResult: undefined,
       memo: undefined,
       parent: undefined,
-      searchAttributes: undefined,
+      searchAttributes: {},
     };
 
     t.deepEqual(recordedCalls, [

packages/test/src/test-workflows.ts

@@ -90,6 +90,7 @@ async function createWorkflow(
       attempt: 1,
       taskTimeoutMs: 1000,
       taskQueue: 'test',
+      searchAttributes: {},
     },
     randomnessSeed: Long.fromInt(1337).toBytes(),
     now: startTime,

packages/worker/src/worker.ts

@@ -1030,10 +1030,11 @@ export class Worker {
                         workflowId,
                         runId: activation.runId,
                         workflowType,
-                        searchAttributes: mapFromPayloads(
-                          searchAttributePayloadConverter,
-                          searchAttributes?.indexedFields
-                        ) as SearchAttributes | undefined,
+                        searchAttributes:
+                          (mapFromPayloads(
+                            searchAttributePayloadConverter,
+                            searchAttributes?.indexedFields
+                          ) as SearchAttributes) || {},
                         memo: await decodeMapFromPayloads(this.options.loadedDataConverter, memo?.fields),
                         parent: convertToParentWorkflowType(parentWorkflowInfo),
                         lastResult: await decodeFromPayloadsAtIndex(

packages/workflow/src/interfaces.ts

@@ -25,7 +25,7 @@ export interface WorkflowInfo {
   /**
    * Indexed information attached to the Workflow Execution
    */
-  searchAttributes?: SearchAttributes;
+  searchAttributes: SearchAttributes;
 
   /**
    * Non-indexed information attached to the Workflow Execution