Skip to content

Commit 095682c

Browse files
authored
chore: Update publishing instructions with regard to sdk-features (#969)
1 parent 5080344 commit 095682c

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ We welcome contributions from the community. To contribute, please start by open
2929

3030
The current maintainers are:
3131

32-
- [Loren `lorensr`](https://github.com/lorensr)
3332
- [Roey `bergundy`](https://github.com/bergundy)
33+
- [James `mjameswh`](https://github.com/mjameswh)
3434

35-
If you'd like to join us, [email Loren](mailto:loren@temporal.io). We'd be happy to have help with any of these things:
35+
If you'd like to join us, [email Roey](mailto:roey@temporal.io). We'd be happy to have help with any of these things:
3636

3737
- Triaging issues
3838
- Reviewing PRs
@@ -167,6 +167,8 @@ git-cliff --tag 1.0.1 v1.0.0..HEAD | pbcopy
167167

168168
- If PRs came from external contributors, thank them & link their github handles: `([#484](link), thanks to [`@user`](https://github.com/user) 🙏)`
169169
- Open PR with CHANGELOG change
170+
- If using a custom [sdk-features](https://github.com/temporalio/sdk-features) branch for PR integration tests, make
171+
sure the branch is fully up-to-date with `sdk-features` `main` before merging the CHANGELOG PR
170172
- Merge PR
171173
- Checkout latest `main`
172174

@@ -217,6 +219,9 @@ npm deprecate temporalio@^1.0.0 "Instead of installing temporalio, we recommend
217219
rm packages/core-bridge/releases/
218220
```
219221

222+
- If using a custom [sdk-features](https://github.com/temporalio/sdk-features/) branch for PR integration tests, merge
223+
that branch into sdk-features `main` and update the SDK workflow definition to trigger `sdk-features` `main`
224+
220225
- If any APIs have changed, open a PR to update [`samples-typescript`](https://github.com/temporalio/samples-typescript/). Once merged, update the `next` branch:
221226

222227
```sh

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ This monorepo contains the following packages:
3737
| [`packages/common/`](packages/common/) | [`@temporalio/common`](https://www.npmjs.com/package/@temporalio/common) |
3838
| [`packages/proto/`](packages/proto/) | [`@temporalio/proto`](https://www.npmjs.com/package/@temporalio/proto) |
3939
| [`packages/interceptors-opentelemetry/`](packages/interceptors-opentelemetry/) | [`@temporalio/interceptors-opentelemetry`](https://www.npmjs.com/package/@temporalio/interceptors-opentelemetry) |
40-
| [`packages/common/lib/internal-workflow/`](packages/common/lib/internal-workflow/) | [`@temporalio/common/lib/internal-workflow`](https://www.npmjs.com/package/@temporalio/common/lib/internal-workflow) |
41-
| [`packages/common/lib/internal-non-workflow/`](packages/common/lib/internal-non-workflow/) | [`@temporalio/common/lib/internal-non-workflow`](https://www.npmjs.com/package/@temporalio/common/lib/internal-non-workflow) |
4240
| [`packages/meta/`](packages/meta/) | [`temporalio`](https://www.npmjs.com/package/@temporalio/meta) (deprecated) |
4341
| [`packages/test/`](packages/test/) | SDK internal tests |
4442
| [`packages/create-project/`](packages/create-project/) | [`@temporalio/create`](https://www.npmjs.com/package/@temporalio/create-project) |
@@ -52,4 +50,4 @@ Thank you to everyone who has contributed 😃🙌
5250

5351
## Contributing
5452

55-
We welcome issues and PRs! Read our [contributing guide](CONTRIBUTING.md) to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to the SDK.
53+
We welcome issues and PRs! Read our [contributing guide](CONTRIBUTING.md) to learn about our development process, how to propose bugfixes and improvements, and how to build and test your changes to the SDK.

0 commit comments

Comments
 (0)