[Fix] Specs failing to shutdown the mock server properly (#66)

* Move wait_for_server into a shared helper

* Run mock server without forking the current process

* Fix Rubocop

Author: antstorm

spec/integration/client_spec.rb

@@ -4,6 +4,7 @@
 require 'temporal/error/failure'
 require 'temporal/error/workflow_failure'
 require 'temporal/interceptor/client'
+require 'support/helpers/test_rpc'
 
 class TestInterceptor < Temporal::Interceptor::Client
   attr_reader :results
@@ -57,18 +58,9 @@ def terminate_workflow(input)
   let(:id) { SecureRandom.uuid }
   let(:workflow) { 'kitchen_sink' }
 
-  def wait_for_server(url)
-    10.times do
-      Temporal::Connection.new("http://#{url}")
-      break
-    rescue Temporal::Bridge::Error
-      sleep(0.5) # delay before retrying
-    end
-  end
-
   before(:all) do
     @server_pid = fork { exec("#{support_path}/go_server/main #{port} #{namespace}") }
-    wait_for_server(url)
+    Helpers::TestRPC.wait("http://#{url}", 10, 0.5)
 
     @worker_pid = fork { exec("#{support_path}/go_worker/main #{url} #{namespace} #{task_queue}") }
   end

spec/integration/connection_spec.rb

@@ -1,31 +1,18 @@
 require 'grpc'
 require 'temporal/connection'
+require 'support/helpers/test_rpc'
 require 'support/mock_server'
 
 describe Temporal::Connection do
   mock_address = '0.0.0.0:4444'.freeze
 
-  def wait_for_mock_server(address, attempts, interval = 1)
-    request = Temporal::Api::WorkflowService::V1::GetSystemInfoRequest.new
-    attempts.times do |i|
-      connection = described_class.new("http://#{address}")
-      connection.get_system_info(request)
-      break
-    rescue StandardError => e
-      puts "Error connecting to a mock server: #{e}. Attempt #{i + 1} / #{attempts}"
-      raise if i + 1 == attempts # re-raise upon exhausting attempts
-
-      sleep interval
-    end
-  end
-
   subject { described_class.new("http://#{mock_address}") }
 
   # TODO: For some reason the Bridge doesn't play well with the server in the same
   #       process throwing SegFaults in cases. Needs further investigation
   before(:all) do
-    @pid = fork { MockServer.run(mock_address) }
-    wait_for_mock_server(mock_address, 10)
+    @pid = fork { exec('bundle exec ruby spec/support/mock_server.rb') }
+    Helpers::TestRPC.wait("http://#{mock_address}", 10)
   end
   after(:all) { Process.kill('QUIT', @pid) }
 

spec/support/helpers/test_rpc.rb

@@ -0,0 +1,19 @@
+require 'temporal/connection'
+
+module Helpers
+  module TestRPC
+    def self.wait(address, max_attempts, interval = 1)
+      request = Temporal::Api::WorkflowService::V1::GetSystemInfoRequest.new
+      max_attempts.times do |i|
+        connection = Temporal::Connection.new(address)
+        connection.get_system_info(request)
+        break
+      rescue StandardError => e
+        puts "Error connecting to a server: #{e}. Attempt #{i + 1} / #{max_attempts}"
+        raise if i + 1 == max_attempts # re-raise upon exhausting attempts
+
+        sleep interval
+      end
+    end
+  end
+end

spec/support/mock_server.rb

@@ -1,3 +1,8 @@
+if __FILE__ == $PROGRAM_NAME
+  $LOAD_PATH << File.expand_path('..', File.dirname(__FILE__))
+  $LOAD_PATH << File.expand_path('../../lib/gen', File.dirname(__FILE__))
+end
+
 require 'grpc'
 require 'support/grpc/temporal/api/workflowservice/v1/service_services_pb'
 
@@ -16,3 +21,7 @@ def self.run(address)
     end
   end
 end
+
+if __FILE__ == $PROGRAM_NAME
+  MockServer.run('0.0.0.0:4444')
+end