Skip to content

Commit 4512224

Browse files
authored
Workflow support (#183)
1 parent 4599b85 commit 4512224

File tree

159 files changed

+14327
-1363
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

159 files changed

+14327
-1363
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
jobs:
1010
build-lint-test:
1111
strategy:
12-
fail-fast: true
12+
fail-fast: false
1313
matrix:
1414
# TODO(cretz): Enable Linux ARM. It's not natively supported with setup-ruby (see
1515
# https://github.com/ruby/setup-ruby#supported-platforms and https://github.com/ruby/setup-ruby/issues/577).
@@ -24,7 +24,7 @@ jobs:
2424
# https://github.com/temporalio/sdk-ruby/issues/172
2525
os: [ubuntu-latest, macos-latest]
2626
# Earliest and latest supported
27-
rubyVersion: ["3.1", "3.3"]
27+
rubyVersion: ["3.2", "3.3"]
2828

2929
include:
3030
- os: ubuntu-latest
@@ -73,4 +73,6 @@ jobs:
7373
7474
- name: Lint, compile, test Ruby
7575
working-directory: ./temporalio
76+
# Timeout just in case there's a hanging part in rake
77+
timeout-minutes: 20
7678
run: bundle exec rake TESTOPTS="--verbose"

README.md

Lines changed: 584 additions & 47 deletions
Large diffs are not rendered by default.

temporalio/.rubocop.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ Layout/LeadingCommentSpace:
2828
# Don't need super for activities
2929
Lint/MissingSuper:
3030
AllowedParentClasses:
31-
- Temporalio::Activity
31+
- Temporalio::Activity::Definition
32+
- Temporalio::Workflow::Definition
3233

3334
# Allow tests to nest methods
3435
Lint/NestedMethodDefinition:
@@ -61,7 +62,7 @@ Metrics/ModuleLength:
6162

6263
# The default is too small
6364
Metrics/PerceivedComplexity:
64-
Max: 25
65+
Max: 40
6566

6667
# We want classes to be documented
6768
Style/Documentation:
@@ -80,6 +81,10 @@ Style/GlobalVars:
8081
Exclude:
8182
- test/**/*
8283

84+
# We're ok with two compound comparisons before doing Array.include?
85+
Style/MultipleComparison:
86+
ComparisonsThreshold: 3
87+
8388
# We want our require lists to be in order
8489
Style/RequireOrder:
8590
Enabled: true

temporalio/.yardopts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
--readme README.md
2+
--protected

temporalio/Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ group :development do
1717
gem 'rbs', '~> 3.5.3'
1818
gem 'rb_sys', '~> 0.9.63'
1919
gem 'rubocop'
20-
gem 'sqlite3', '~> 1.4'
20+
gem 'sqlite3'
2121
gem 'steep', '~> 1.7.1'
2222
gem 'yard'
2323
end

0 commit comments

Comments
 (0)