Skip to content

Commit ec96780

Browse files
committed
TODO cleanup
1 parent 718f9af commit ec96780

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

temporalio/common.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1020,12 +1020,12 @@ def __post_init__(self):
10201020
class VersioningBehavior(Enum):
10211021
"""Specifies when a workflow might move from a worker of one Build Id to another.
10221022
1023-
NOTE: Experimental API.
1023+
WARNING: Experimental API.
10241024
"""
10251025

10261026
UNSPECIFIED = 1
10271027
""" An unspecified versioning behavior. By default, workers opting into worker versioning will
1028-
be required to specify a behavior. See TODO: Add link to worker options."""
1028+
be required to specify a behavior. See :py:class:`temporalio.worker.WorkerDeploymentOptions`."""
10291029
PINNED = 2
10301030
"""The workflow will be pinned to the current Build ID unless manually moved."""
10311031
AUTO_UPGRADE = 3
@@ -1046,7 +1046,7 @@ def _to_proto(self) -> temporalio.api.enums.v1.VersioningBehavior.ValueType:
10461046
class WorkerDeploymentVersion:
10471047
"""Represents the version of a specific worker deployment.
10481048
1049-
NOTE: Experimental API.
1049+
WARNING: Experimental API.
10501050
"""
10511051

10521052
_deployment_name: str

temporalio/worker/_workflow.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,6 @@ async def _handle_activation(
336336

337337
# Always set the run ID on the completion
338338
completion.run_id = act.run_id
339-
# TODO: Could set versioning behavior here?
340339

341340
# Encode the completion if there's a codec and not cache remove job
342341
if self._data_converter.payload_codec:

temporalio/workflow.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,6 @@ def defn(
9999
) -> Callable[[ClassType], ClassType]: ...
100100

101101

102-
# TODO: Pass versioning behavior here or do it via a method in dynamic workflow impl like Java?
103-
104-
105102
def defn(
106103
cls: Optional[ClassType] = None,
107104
*,

0 commit comments

Comments
 (0)