Skip to content

Commit d5e9f88

Browse files
committed
Do not handle cancel-before-start
1 parent 90a2449 commit d5e9f88

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

temporalio/worker/_workflow_instance.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -865,11 +865,14 @@ def _apply_resolve_nexus_operation_start(
865865
# `ResolveNexusOperation` job will be in the same activation.
866866
handle._resolve_start_success(None)
867867
elif job.HasField("cancelled_before_start"):
868-
# The operation was cancelled before it was ever sent to server (same WFT).
869-
# Note that core will still send a `ResolveNexusOperation` job in the same
870-
# activation, so there does not need to be an exceptional case for this in
871-
# lang.
872-
# TODO(nexus-preview): confirm appropriate to take no action here
868+
# From proto docs: the operation was cancelled before it was ever
869+
# sent to server (same WFT). Note that core will still send a
870+
# `ResolveNexusOperation` job in the same activation, so there does
871+
# not need to be an exceptional case for this in lang.
872+
#
873+
# We do not resolve start here because it will be resolved in the by
874+
# handle._resolve_failure when handling the follow-up
875+
# ResolveNexusOperation from core.
873876
pass
874877
else:
875878
raise ValueError(f"Unknown Nexus operation start status: {job}")

0 commit comments

Comments
 (0)