Make a pass through prerelease TODOs

Author: dandavison

temporalio/nexus/__init__.py

@@ -14,8 +14,3 @@
 from ._operation_context import logger as logger
 from ._operation_handlers import cancel_operation as cancel_operation
 from ._token import WorkflowHandle as WorkflowHandle
-
-
-# TODO(nexus-prerelease) WARN temporal_sdk_core::worker::nexus: Failed to parse nexus timeout header value '9.155416ms'
-# 2025-06-25T12:58:05.749589Z  WARN temporal_sdk_core::worker::nexus: Failed to parse nexus timeout header value '9.155416ms'
-# 2025-06-25T12:58:05.763052Z  WARN temporal_sdk_core::worker::nexus: Nexus task not found on completion. This may happen if the operation has already been cancelled but completed anyway. details=Status { code: NotFound, message: "Nexus task not found or already expired", details: b"\x08\x05\x12'Nexus task not found or already expired\x1aB\n@type.googleapis.com/temporal.api.errordetails.v1.NotFoundFailure", metadata: MetadataMap { headers: {"content-type": "application/grpc"} }, source: None }

temporalio/nexus/_operation_context.py

@@ -193,7 +193,7 @@ def from_start_operation_context(
         )
 
     # Overload for single-param workflow
-    # TODO(nexus-prerelease): bring over other overloads
+    # TODO(nexus-prerelease)*: bring over other overloads
     async def start_workflow(
         self,
         workflow: MethodAsyncSingleParam[SelfType, ParamType, ReturnType],

temporalio/types.py

@@ -81,7 +81,7 @@ class MethodAsyncSingleParam(
 ):
     """Generic callable type."""
 
-    # TODO(nexus-prerelease): review changes to signatures in this file
+    # TODO(nexus-prerelease)*: review changes to signatures in this file
     def __call__(
         self, __self: ProtocolSelfType, __arg: ProtocolParamType
     ) -> Awaitable[ProtocolReturnType]:

temporalio/worker/_activity.py

@@ -201,8 +201,9 @@ async def drain_poll_queue(self) -> None:
 
     # Only call this after run()/drain_poll_queue() have returned. This will not
     # raise an exception.
-    # TODO(nexus-prerelease): based on the comment above it looks like the intention may have been to use
-    # return_exceptions=True
+    # TODO(nexus-preview): based on the comment above it looks like the intention may have been to use
+    # return_exceptions=True. Change this for nexus and activity and change call sites to consume entire
+    # stream and then raise first exception
     async def wait_all_completed(self) -> None:
         running_tasks = [v.task for v in self._running_activities.values() if v.task]
         if running_tasks:

temporalio/worker/_interceptor.py

@@ -304,7 +304,6 @@ class StartNexusOperationInput(Generic[InputT, OutputT]):
     _operation_name: str = field(init=False, repr=False)
     _input_type: Optional[Type[InputT]] = field(init=False, repr=False)
 
-    # TODO(nexus-prerelease): update this logic to handle service impl start methods
     def __post_init__(self) -> None:
         if isinstance(self.operation, nexusrpc.Operation):
             self._operation_name = self.operation.name

temporalio/worker/_nexus.py

@@ -191,7 +191,7 @@ async def _handle_cancel_operation_task(
                 ),
             )
         else:
-            # TODO(nexus-prerelease): when do we use ack_cancel?
+            # TODO(nexus-preview): ack_cancel completions?
             completion = temporalio.bridge.proto.nexus.NexusTaskCompletion(
                 task_token=task_token,
                 completed=temporalio.api.nexus.v1.Response(

temporalio/worker/_worker.py

@@ -311,7 +311,7 @@ def __init__(
             nexus_task_poller_behavior: Specify the behavior of Nexus task polling.
                 Defaults to a 5-poller maximum.
         """
-        # TODO(nexus-prerelease): max_concurrent_nexus_tasks / tuner support
+        # TODO(nexus-preview): max_concurrent_nexus_tasks / tuner support
         if not (activities or nexus_service_handlers or workflows):
             raise ValueError(
                 "At least one activity, Nexus service, or workflow must be specified"

temporalio/worker/_workflow_instance.py

@@ -869,7 +869,7 @@ def _apply_resolve_nexus_operation_start(
             # Note that core will still send a `ResolveNexusOperation` job in the same
             # activation, so there does not need to be an exceptional case for this in
             # lang.
-            # TODO(nexus-prerelease): confirm appropriate to take no action here
+            # TODO(nexus-preview): confirm appropriate to take no action here
             pass
         else:
             raise ValueError(f"Unknown Nexus operation start status: {job}")
@@ -3010,7 +3010,7 @@ def __init__(
 
     @property
     def operation_token(self) -> Optional[str]:
-        # TODO(nexus-prerelease): How should this behave?
+        # TODO(nexus-preview): How should this behave?
         # Java has a separate class that only exists if the operation token exists:
         # https://github.com/temporalio/sdk-java/blob/master/temporal-sdk/src/main/java/io/temporal/internal/sync/NexusOperationExecutionImpl.java#L26
         # And Go similar:

temporalio/workflow.py

@@ -4384,25 +4384,16 @@ async def execute_child_workflow(
     return await handle
 
 
-# TODO(nexus-prerelease): ABC / inherit from asyncio.Task?
 class NexusOperationHandle(Generic[OutputT]):
     def cancel(self) -> bool:
-        # TODO(nexus-prerelease): docstring
         """
-        Call task.cancel() on the asyncio task that is backing this handle.
-
-        From asyncio docs:
-
-        Cancel the future and schedule callbacks.
-
-        If the future is already done or cancelled, return False. Otherwise, change the future's state to cancelled, schedule the callbacks and return True.
+        Request cancellation of the operation.
         """
         raise NotImplementedError
 
     def __await__(self) -> Generator[Any, Any, OutputT]:
         raise NotImplementedError
 
-    # TODO(nexus-prerelease): check SDK-wide consistency for @property vs nullary accessor methods.
     @property
     def operation_token(self) -> Optional[str]:
         raise NotImplementedError

tests/conftest.py

@@ -123,13 +123,13 @@ async def env(env_type: str) -> AsyncGenerator[WorkflowEnvironment, None]:
             ],
             dev_server_download_version=DEV_SERVER_DOWNLOAD_VERSION,
         )
+        # TODO(nexus-preview): expose this in a more principled way
         env._http_port = http_port  # type: ignore
     elif env_type == "time-skipping":
         env = await WorkflowEnvironment.start_time_skipping()
     else:
         env = WorkflowEnvironment.from_client(await Client.connect(env_type))
 
-    # TODO(nexus-prerelease): expose this in a principled way
     yield env
     await env.shutdown()