Improves typing of SearchAttributes (#76)

Author: nathanielobrown

temporalio/common.py

@@ -130,12 +130,14 @@ class QueryRejectCondition(IntEnum):
     """See :py:attr:`temporalio.api.enums.v1.QueryRejectCondition.QUERY_REJECT_CONDITION_NOT_COMPLETED_CLEANLY`."""
 
 
-SearchAttributeValue: TypeAlias = Union[str, int, float, bool, datetime]
-
 # We choose to make this a list instead of an iterable so we can catch if people
 # are not sending lists each time but maybe accidentally sending a string (which
 # is iterable)
-SearchAttributes: TypeAlias = Mapping[str, List[SearchAttributeValue]]
+SearchAttributeValues: TypeAlias = Union[
+    List[str], List[int], List[float], List[bool], List[datetime]
+]
+
+SearchAttributes: TypeAlias = Mapping[str, SearchAttributeValues]
 
 
 # Should be set as the "arg" argument for _arg_or_args checks where the argument

temporalio/converter.py

@@ -620,7 +620,7 @@ def encode_search_attributes(
 
 
 def encode_search_attribute_values(
-    vals: List[temporalio.common.SearchAttributeValue],
+    vals: temporalio.common.SearchAttributeValues,
 ) -> temporalio.api.common.v1.Payload:
     """Convert search attribute values into a payload.
 

tests/worker/test_workflow.py

@@ -1192,13 +1192,14 @@ def get_search_attributes(self) -> Mapping[str, Mapping[str, Any]]:
 
     @workflow.signal
     def do_search_attribute_update(self) -> None:
+        empty_float_list: List[float] = []
         workflow.upsert_search_attributes(
             {
                 f"{sa_prefix}text": ["text3"],
                 # We intentionally leave keyword off to confirm it still comes back
                 f"{sa_prefix}int": [123, 456],
                 # Empty list to confirm removed
-                f"{sa_prefix}double": [],
+                f"{sa_prefix}double": empty_float_list,
                 f"{sa_prefix}bool": [False],
                 f"{sa_prefix}datetime": [
                     datetime(2003, 4, 5, 6, 7, 8, tzinfo=timezone(timedelta(hours=9)))