Skip to content

Commit 9ca74c9

Browse files
committed
Default to 1, and code review suggestions
1 parent dedb389 commit 9ca74c9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

temporalio/nexus/_operation_context.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -561,13 +561,13 @@ def _event_reference_from_query_params(
561561
"""
562562
Return an EventReference from the query params or raise ValueError.
563563
"""
564-
[reference_type] = query_params.get("referenceType", [])
564+
[reference_type] = query_params.get("referenceType") or [None]
565565
if reference_type != "EventReference":
566566
raise ValueError(
567567
f"Expected Nexus link URL query parameter referenceType to be EventReference but got: {reference_type}"
568568
)
569569
# event type
570-
[raw_event_type_name] = query_params.get(LINK_EVENT_TYPE_PARAM_NAME, [None])
570+
[raw_event_type_name] = query_params.get(LINK_EVENT_TYPE_PARAM_NAME) or [None]
571571
if not raw_event_type_name:
572572
raise ValueError(f"query params do not contain event type: {query_params}")
573573
if raw_event_type_name.startswith("EVENT_TYPE_"):
@@ -580,8 +580,8 @@ def _event_reference_from_query_params(
580580
raise ValueError(f"Invalid event type name: {raw_event_type_name}")
581581

582582
# event id
583-
event_id = 0
584-
[raw_event_id] = query_params.get(LINK_EVENT_ID_PARAM_NAME, [None])
583+
event_id = 1
584+
[raw_event_id] = query_params.get(LINK_EVENT_ID_PARAM_NAME) or [None]
585585
if raw_event_id:
586586
try:
587587
event_id = int(raw_event_id)

0 commit comments

Comments
 (0)