Skip to content

Commit 6fbc4c5

Browse files
authored
Set default model activity timeout to 60s (#941)
* Set default model activity timeout to 60s * Make model activity params optional
1 parent ecfb72f commit 6fbc4c5

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

temporalio/contrib/openai_agents/model_parameters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class ModelActivityParameters:
2020
task_queue: Optional[str] = None
2121
"""Specific task queue to use for model activities."""
2222

23-
schedule_to_close_timeout: Optional[timedelta] = None
23+
schedule_to_close_timeout: Optional[timedelta] = timedelta(seconds=60)
2424
"""Maximum time from scheduling to completion."""
2525

2626
schedule_to_start_timeout: Optional[timedelta] = None

temporalio/contrib/openai_agents/temporal_openai_agents.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,23 @@
11
"""Initialize Temporal OpenAI Agents overrides."""
22

33
from contextlib import contextmanager
4-
from datetime import timedelta
54
from typing import Optional
65

76
from agents import set_trace_provider
87
from agents.run import get_default_agent_runner, set_default_agent_runner
98
from agents.tracing import get_trace_provider
109
from agents.tracing.provider import DefaultTraceProvider
1110

12-
from temporalio.common import Priority, RetryPolicy
1311
from temporalio.contrib.openai_agents._openai_runner import TemporalOpenAIRunner
1412
from temporalio.contrib.openai_agents._temporal_trace_provider import (
1513
TemporalTraceProvider,
1614
)
1715
from temporalio.contrib.openai_agents.model_parameters import ModelActivityParameters
18-
from temporalio.workflow import ActivityCancellationType, VersioningIntent
1916

2017

2118
@contextmanager
2219
def set_open_ai_agent_temporal_overrides(
23-
model_params: ModelActivityParameters,
20+
model_params: Optional[ModelActivityParameters] = None,
2421
auto_close_tracing_in_workflows: bool = False,
2522
):
2623
"""Configure Temporal-specific overrides for OpenAI agents.
@@ -41,11 +38,15 @@ def set_open_ai_agent_temporal_overrides(
4138
4239
Args:
4340
model_params: Configuration parameters for Temporal activity execution of model calls.
41+
auto_close_tracing_in_workflows: If set to true, close tracing spans immediately.
4442
4543
Returns:
4644
A context manager that yields the configured TemporalTraceProvider.
4745
4846
"""
47+
if model_params is None:
48+
model_params = ModelActivityParameters()
49+
4950
if (
5051
not model_params.start_to_close_timeout
5152
and not model_params.schedule_to_close_timeout

0 commit comments

Comments
 (0)