Skip to content

Commit 6dceaca

Browse files
committed
TODOs
- fetch result - error handling
1 parent 174ff3f commit 6dceaca

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

temporalio/nexus/_operation_handlers.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ async def fetch_result(
104104
"Temporal Nexus operation handlers do not support fetching the operation result."
105105
)
106106
# An implementation is provided for future reference:
107+
# TODO: honor `wait` param and Request-Timeout header
107108
try:
108109
nexus_handle = WorkflowHandle[OutputT].from_token(token)
109110
except Exception as err:

temporalio/worker/_nexus.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,6 +341,8 @@ async def _operation_error_to_proto(
341341
self,
342342
err: nexusrpc.OperationError,
343343
) -> temporalio.api.nexus.v1.UnsuccessfulOperationError:
344+
# TODO(nexus-prerelease): why are we accessing __cause__ here for OperationError
345+
# and not for HandlerError?
344346
cause = err.__cause__
345347
if cause is None:
346348
cause = Exception(*err.args).with_traceback(err.__traceback__)

0 commit comments

Comments
 (0)