Remove dynamic behavior getter for now

Sushisource · Sushisource · commit 56514838247c · 2025-04-11T11:42:01.000-07:00
diff --git a/temporalio/worker/_workflow.py b/temporalio/worker/_workflow.py
@@ -136,23 +136,14 @@ def __init__(
             if defn.name in self._workflows:
                 raise ValueError(f"More than one workflow named {defn.name}")
             if should_enforce_versioning_behavior:
-                not_in_annotation = defn.versioning_behavior in [
+                if defn.versioning_behavior in [
                     None,
                     temporalio.common.VersioningBehavior.UNSPECIFIED,
-                ]
-                if defn.name:
-                    if not_in_annotation:
-                        raise ValueError(
-                            f"Workflow {defn.name} must specify a versioning behavior using "
-                            "the `versioning_behavior` argument to `@workflow.defn`."
-                        )
-                else:
-                    if not_in_annotation and defn.dynamic_versioning_behavior is None:
-                        raise ValueError(
-                            f"Dynamic Workflow {defn.cls.__qualname__} must specify a versioning "
-                            "behavior using `@workflow.dynamic_versioning_behavior` or the "
-                            "`versioning_behavior` argument to `@workflow.defn`."
-                        )
+                ]:
+                    raise ValueError(
+                        f"Workflow {defn.name} must specify a versioning behavior using "
+                        "the `versioning_behavior` argument to `@workflow.defn`."
+                    )
 
             # Prepare the workflow with the runner (this will error in the
             # sandbox if an import fails somehow)
diff --git a/temporalio/worker/_workflow_instance.py b/temporalio/worker/_workflow_instance.py
@@ -414,20 +414,6 @@ def activate(
                     )
                 activation_err = None
 
-        # If this workflow is dynamic, try calling the dynamic versioning behavior
-        if self._defn.name is None:
-            dvb = self.workflow_get_dynamic_versioning_behavior()
-            if dvb:
-                with self._as_read_only():
-                    vb = dvb()
-                    if (
-                        vb
-                        != temporalio.api.enums.v1.VersioningBehavior.VERSIONING_BEHAVIOR_UNSPECIFIED
-                    ):
-                        self._current_completion.successful.versioning_behavior = (
-                            vb.value
-                        )
-
         # If we're deleting, there better be no more tasks. It is important for
         # the integrity of the system that we check this. If there are tasks
         # remaining, they and any associated coroutines will get garbage
@@ -1040,14 +1026,6 @@ def workflow_get_update_validator(self, name: Optional[str]) -> Optional[Callabl
         # Bind if a method
         return defn.bind_validator(self._object) if defn.is_method else defn.validator
 
-    def workflow_get_dynamic_versioning_behavior(
-        self,
-    ) -> Optional[Callable[[], temporalio.common.VersioningBehavior]]:
-        defn = self._defn.dynamic_versioning_behavior
-        if not defn:
-            return None
-        return temporalio.workflow._bind_method(self._object, defn)
-
     def workflow_info(self) -> temporalio.workflow.Info:
         return self._outbound.info()
 
diff --git a/temporalio/workflow.py b/temporalio/workflow.py
@@ -223,25 +223,6 @@ class UnfinishedSignalHandlersWarning(RuntimeWarning):
     """The workflow exited before all signal handlers had finished executing."""
 
 
-def dynamic_versioning_behavior(
-    fn: MethodSyncNoParam[SelfType, temporalio.common.VersioningBehavior],
-) -> MethodSyncNoParam[SelfType, temporalio.common.VersioningBehavior]:
-    """Decorator for specifying versioning behavior in dynamic workflows.
-
-    This function must be read-only and not mutate workflow state. Any mutation could lead to
-    nondeterministic behavior. If the workflow function specifies a `versioning_behavior` on
-    both ``@workflow.run`` and with a getter, the getter's value will be used whenever it is not
-    ``VersioningBehavior.UNSPECIFIED``.
-
-    WARNING: This setting is experimental.
-
-    Args:
-        fn: The method to decorate
-    """
-    setattr(fn, "__temporal_dynamic_versioning_behavior", True)
-    return fn
-
-
 @overload
 def signal(
     fn: CallableSyncOrAsyncReturnNoneType,
@@ -1447,7 +1428,6 @@ class _Definition:
     arg_types: Optional[List[Type]] = None
     ret_type: Optional[Type] = None
     versioning_behavior: Optional[temporalio.common.VersioningBehavior] = None
-    dynamic_versioning_behavior: Optional[CallableSyncNoParam] = None
 
     @staticmethod
     def from_class(cls: Type) -> Optional[_Definition]:
@@ -1516,7 +1496,6 @@ def _apply_to_class(
         signals: Dict[Optional[str], _SignalDefinition] = {}
         queries: Dict[Optional[str], _QueryDefinition] = {}
         updates: Dict[Optional[str], _UpdateDefinition] = {}
-        dynamic_versioning_behavior: Optional[CallableSyncNoParam] = None
         for name, member in inspect.getmembers(cls):
             if hasattr(member, "__temporal_workflow_run"):
                 seen_run_attr = True
@@ -1560,15 +1539,6 @@ def _apply_to_class(
                     queries[query_defn.name] = query_defn
             elif name == "__init__" and hasattr(member, "__temporal_workflow_init"):
                 init_fn = member
-            elif hasattr(member, "__temporal_dynamic_versioning_behavior"):
-                if workflow_name:
-                    issues.append(
-                        "Non-dynamic workflows should not specify "
-                        "@workflow.dynamic_versioning_behavior, which was found on "
-                        f"{cls.__qualname__}.{name}. Use the versioning_behavior "
-                        "argument to @workflow.run instead."
-                    )
-                dynamic_versioning_behavior = member
             elif isinstance(member, UpdateMethodMultiParam):
                 update_defn = member._defn
                 if update_defn.name in updates:
@@ -1652,7 +1622,6 @@ def _apply_to_class(
             sandboxed=sandboxed,
             failure_exception_types=failure_exception_types,
             versioning_behavior=versioning_behavior,
-            dynamic_versioning_behavior=dynamic_versioning_behavior,
         )
         setattr(cls, "__temporal_workflow_definition", defn)
         setattr(run_fn, "__temporal_workflow_definition", defn)
diff --git a/tests/test_workflow.py b/tests/test_workflow.py
@@ -225,16 +225,12 @@ def update2(self, arg1: str):
     def base_update(self):
         pass
 
-    @workflow.dynamic_versioning_behavior
-    def i_shouldnt_exist(self) -> VersioningBehavior:
-        return VersioningBehavior.PINNED
-
 
 def test_workflow_defn_bad():
     with pytest.raises(ValueError) as err:
         workflow.defn(BadDefn)
 
-    assert "Invalid workflow class for 10 reasons" in str(err.value)
+    assert "Invalid workflow class for 9 reasons" in str(err.value)
     assert "Missing @workflow.run method" in str(err.value)
     assert (
         "Multiple signal methods found for signal1 (at least on signal2 and signal1)"
@@ -268,10 +264,6 @@ def test_workflow_defn_bad():
         "@workflow.update defined on BadDefnBase.base_update but not on the override"
         in str(err.value)
     )
-    assert (
-        "Non-dynamic workflows should not specify @workflow.dynamic_versioning_behavior, which "
-        "was found on BadDefn.i_shouldnt_exist" in str(err.value)
-    )
 
 
 def test_workflow_defn_local_class():
diff --git a/tests/worker/test_worker.py b/tests/worker/test_worker.py
@@ -775,26 +775,18 @@ async def run(self, args: Sequence[RawValue]) -> str:
         return "dynamic"
 
 
-@workflow.defn(dynamic=True)
-class DynamicWorkflowVersioningWithGetter:
-    @workflow.run
-    async def run(self, args: Sequence[RawValue]) -> str:
-        return "dynamic"
-
-    @workflow.dynamic_versioning_behavior
-    def huh(self) -> VersioningBehavior:
-        return VersioningBehavior.PINNED
-
-
-async def _test_dynamic_workflow_versioning(
-    client: Client, workflow_class, expected_versioning_behavior
+async def test_worker_deployment_dynamic_workflow_on_run(
+    client: Client, env: WorkflowEnvironment
 ):
+    if env.supports_time_skipping:
+        pytest.skip("Test Server doesn't support worker deployments")
+
     deployment_name = f"deployment-dynamic-{uuid.uuid4()}"
     worker_v1 = WorkerDeploymentVersion(deployment_name=deployment_name, build_id="1.0")
 
     async with new_worker(
         client,
-        workflow_class,
+        DynamicWorkflowVersioningOnDefn,
         deployment_config=WorkerDeploymentConfig(
             version=worker_v1,
             use_worker_versioning=True,
@@ -820,37 +812,11 @@ async def _test_dynamic_workflow_versioning(
         assert any(
             event.HasField("workflow_task_completed_event_attributes")
             and event.workflow_task_completed_event_attributes.versioning_behavior
-            == expected_versioning_behavior
+            == temporalio.api.enums.v1.VersioningBehavior.VERSIONING_BEHAVIOR_PINNED
             for event in history.events
         )
 
 
-async def test_worker_deployment_dynamic_workflow_on_run(
-    client: Client, env: WorkflowEnvironment
-):
-    if env.supports_time_skipping:
-        pytest.skip("Test Server doesn't support worker deployments")
-
-    await _test_dynamic_workflow_versioning(
-        client,
-        DynamicWorkflowVersioningOnDefn,
-        temporalio.api.enums.v1.VersioningBehavior.VERSIONING_BEHAVIOR_PINNED,
-    )
-
-
-async def test_worker_deployment_dynamic_workflow_getter(
-    client: Client, env: WorkflowEnvironment
-):
-    if env.supports_time_skipping:
-        pytest.skip("Test Server doesn't support worker deployments")
-
-    await _test_dynamic_workflow_versioning(
-        client,
-        DynamicWorkflowVersioningWithGetter,
-        temporalio.api.enums.v1.VersioningBehavior.VERSIONING_BEHAVIOR_PINNED,
-    )
-
-
 @workflow.defn
 class NoVersioningAnnotationWorkflow:
     @workflow.run
