Skip to content

Last cached activity heartbeat should be discarded or drained with activity completion or worker shutdown #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Spikhalskiy opened this issue Jun 9, 2022 · 0 comments · May be fixed by #2526
Open

Last cached activity heartbeat should be discarded or drained with activity completion or worker shutdown #1256

Spikhalskiy opened this issue Jun 9, 2022 · 0 comments · May be fixed by #2526
Labels
enhancement User experience
Milestone
Next

Comments

@Spikhalskiy
Copy link
Contributor

Spikhalskiy commented Jun 9, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, if an Activity heartbeat too often and the heartbeat gets throttled and cached, an activity finishes without draining or canceling the heartbeat.

Describe the solution you'd like
The last cached heartbeat should be either drained before the activity completion or discarded/canceled.
This also should be happening during graceful worker shutdown.
@Spikhalskiy Spikhalskiy changed the title Last cached activity heartbeat should be discarded or drained with activity completion Last cached activity heartbeat should be discarded or drained with activity completion or worker shutdown Nov 9, 2022
@Spikhalskiy Spikhalskiy added this to the Next milestone Nov 9, 2022
@Quinn-With-Two-Ns Quinn-With-Two-Ns added the enhancement User experience label May 23, 2023
@josh-berry josh-berry removed the task label Dec 17, 2024
@Quinn-With-Two-Ns Quinn-With-Two-Ns linked a pull request May 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement User experience
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Cancel pending heartbeat when activity completes Quinn-With-Two-Ns/sdk-java
3 participants
@Spikhalskiy @josh-berry @Quinn-With-Two-Ns