Skip to content

Commit e5bb3a5

Browse files
Bump edge Java SDK test version (#2507)
Update CI to use Java 23
1 parent 7a09384 commit e5bb3a5

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Java
2222
uses: actions/setup-java@v4
2323
with:
24-
java-version: "21"
24+
java-version: "23"
2525
distribution: "temurin"
2626

2727
- name: Set up Gradle
@@ -61,7 +61,7 @@ jobs:
6161
uses: actions/setup-java@v4
6262
with:
6363
java-version: |
64-
21
64+
23
6565
11
6666
distribution: "temurin"
6767

build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ ext {
6363
logbackVersion = project.hasProperty("edgeDepsTest") ? '1.3.5' : '1.2.11'
6464
mockitoVersion = '5.14.2'
6565
junitVersion = '4.13.2'
66+
// Edge Dependencies are used by tests to validate the SDK with the latest version of various libraries.
67+
// Not just the version of the library the SDK is built against.
68+
protoVersionEdge = '4.30.2'
69+
grpcVersionEdge = '1.72.0'
6670
}
6771

6872
apply from: "$rootDir/gradle/versioning.gradle"

temporal-sdk/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ dependencies {
3030
testImplementation 'pl.pragmatists:JUnitParams:1.1.1'
3131
testImplementation group: 'ch.qos.logback', name: 'logback-classic', version: "${logbackVersion}"
3232
if (project.hasProperty("edgeDepsTest")) {
33-
testRuntimeOnly "com.google.protobuf:protobuf-java:4.29.3"
34-
testRuntimeOnly "com.google.protobuf:protobuf-java-util:4.29.3"
33+
testRuntimeOnly "com.google.protobuf:protobuf-java:$protoVersionEdge"
34+
testRuntimeOnly "com.google.protobuf:protobuf-java-util:$protoVersionEdge"
35+
testRuntimeOnly "io.grpc:grpc-bom:$grpcVersionEdge"
3536
}
3637
}
3738

temporal-sdk/src/test/java/io/temporal/client/schedules/ScheduleTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,6 @@ public void limitedActionSchedule() {
183183
ScheduleDescription description = handle.describe();
184184
Assert.assertEquals(0, description.getSchedule().getState().getRemainingActions());
185185
Assert.assertEquals(true, description.getSchedule().getState().isLimitedAction());
186-
Assert.assertEquals(
187-
3,
188-
description.getInfo().getRecentActions().size()
189-
+ description.getInfo().getRunningActions().size());
190186
// Cleanup schedule
191187
handle.delete();
192188
}

temporal-serviceclient/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ dependencies {
3030
testImplementation "org.mockito:mockito-core:${mockitoVersion}"
3131

3232
if (project.hasProperty("edgeDepsTest")) {
33-
testRuntimeOnly "com.google.protobuf:protobuf-java:4.29.3"
34-
testRuntimeOnly "com.google.protobuf:protobuf-java-util:4.29.3"
33+
testRuntimeOnly "com.google.protobuf:protobuf-java:$protoVersionEdge"
34+
testRuntimeOnly "com.google.protobuf:protobuf-java-util:$protoVersionEdge"
35+
testRuntimeOnly "io.grpc:grpc-bom:$grpcVersionEdge"
3536
}
3637
testRuntimeOnly "ch.qos.logback:logback-classic:${logbackVersion}"
3738
}

0 commit comments

Comments
 (0)