Skip to content

Commit f2e056c

Browse files
authored
Update GRPC failure to new proto error (#952)
* Update GRPC failure to new proto error * Formatting
1 parent 99b25ed commit f2e056c

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

core/src/worker/workflow/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,10 +405,9 @@ impl Workflows {
405405
),
406406
force_cause: 0,
407407
};
408-
// TODO: tim - Update workflow cause when API is ready
409408
let new_outcome = FailedActivationWFTReport::Report(
410409
task_token,
411-
WorkflowTaskFailedCause::WorkflowWorkerUnhandledFailure,
410+
WorkflowTaskFailedCause::GrpcMessageTooLarge,
412411
failure,
413412
);
414413
self.handle_activation_failed(run_id, completion_time, new_outcome)

tests/cloud_tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ use temporal_client::{
77
Client, ClientOptionsBuilder, ClientTlsConfig, RetryClient, TlsConfig, WorkflowClientTrait,
88
};
99
use temporal_sdk::WfContext;
10+
use temporal_sdk_core_protos::temporal::api::enums::v1::WorkflowTaskFailedCause::GrpcMessageTooLarge;
1011
use temporal_sdk_core_protos::temporal::api::{
1112
enums::v1::{EventType, WorkflowTaskFailedCause::WorkflowWorkerUnhandledFailure},
1213
history::v1::history_event::Attributes::WorkflowTaskFailedEventAttributes,
@@ -76,8 +77,7 @@ async fn grpc_message_too_large_test() {
7677
assert!(starter.get_history().await.events.iter().any(|e| {
7778
e.event_type == EventType::WorkflowTaskFailed as i32
7879
&& if let WorkflowTaskFailedEventAttributes(attr) = e.attributes.as_ref().unwrap() {
79-
// TODO tim: Change to custom cause
80-
attr.cause == WorkflowWorkerUnhandledFailure as i32
80+
attr.cause == GrpcMessageTooLarge as i32
8181
&& attr.failure.as_ref().unwrap().message == "GRPC Message too large"
8282
} else {
8383
false

tests/integ_tests/worker_tests.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ use temporal_sdk_core_api::{
1515
errors::WorkerValidationError,
1616
worker::{PollerBehavior, WorkerConfigBuilder, WorkerVersioningStrategy},
1717
};
18+
use temporal_sdk_core_protos::temporal::api::enums::v1::WorkflowTaskFailedCause::GrpcMessageTooLarge;
1819
use temporal_sdk_core_protos::{
1920
coresdk::workflow_completion::{
2021
Failure, WorkflowActivationCompletion, workflow_activation_completion::Status,
2122
},
2223
temporal::api::{
23-
enums::v1::{EventType, WorkflowTaskFailedCause::WorkflowWorkerUnhandledFailure},
24-
failure::v1::Failure as InnerFailure,
24+
enums::v1::EventType, failure::v1::Failure as InnerFailure,
2525
history::v1::history_event::Attributes::WorkflowTaskFailedEventAttributes,
2626
},
2727
};
@@ -188,8 +188,7 @@ async fn oversize_grpc_message() {
188188
assert!(starter.get_history().await.events.iter().any(|e| {
189189
e.event_type == EventType::WorkflowTaskFailed as i32
190190
&& if let WorkflowTaskFailedEventAttributes(attr) = e.attributes.as_ref().unwrap() {
191-
// TODO tim: Change to custom cause
192-
attr.cause == WorkflowWorkerUnhandledFailure as i32
191+
attr.cause == GrpcMessageTooLarge as i32
193192
&& attr.failure.as_ref().unwrap().message == "GRPC Message too large"
194193
} else {
195194
false

0 commit comments

Comments
 (0)