Fix child wf state machine returning fatal instead of NDE (#536)

Sushisource · Sushisource · commit 3adb89a46b3b · 2023-05-12T10:14:40.000-07:00
diff --git a/core/src/worker/workflow/machines/child_workflow_state_machine.rs b/core/src/worker/workflow/machines/child_workflow_state_machine.rs
@@ -531,7 +531,7 @@ impl TryFrom<HistEventData> for ChildWorkflowMachineEvents {
                 Self::ChildWorkflowExecutionCancelled
             }
             _ => {
-                return Err(WFMachinesError::Fatal(format!(
+                return Err(WFMachinesError::Nondeterminism(format!(
                     "Child workflow machine does not handle this event: {e:?}"
                 )))
             }

Original file line number	Diff line number	Diff line change
`@@ -531,7 +531,7 @@ impl TryFrom<HistEventData> for ChildWorkflowMachineEvents {`
`531`	`531`	`Self::ChildWorkflowExecutionCancelled`
`532`	`532`	`}`
`533`	`533`	`_ => {`
`534`		`- return Err(WFMachinesError::Fatal(format!(`
	`534`	`+ return Err(WFMachinesError::Nondeterminism(format!(`
`535`	`535`	`"Child workflow machine does not handle this event: {e:?}"`
`536`	`536`	`)))`
`537`	`537`	`}`