Skip to content

Warn when the server-provided task start time is fairly different than time SDK begins processing the task #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 9 tasks
cretz opened this issue Apr 18, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Apr 18, 2025

Describe the solution you'd like

There are two common situations where the server task start time (activities and workflows) could be different than SDK side when the SDK starts processing the task (not when polled unless it's the same in the SDK language):

  • Clock skew - server clock is different than worker clock
  • Worker slowdown between poll response and processing - so for Python for instance, could be enqueued on a thread pool executor instead of processed immediately

We should issue a warning if the difference in these times is significant. TBD the exact values, but early thoughts are "if the task start time is +/- 1 minute from current worker system time when task is started". For Core SDKs, this needs to be done in lang because it's important to check when the task is actually being worked on and not when it's received from server, and only lang knows that. It's TBD on whether this users need to be able to disable/customize this.

Per-SDK Tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant