[Feature Request] Upsert TemporalChangeVersion on patch

[lorensr]

Is your feature request related to a problem? Please describe.

Can't do:

tctl workflow list --query='TemporalChangeVersion="<change_id>-<version_id>"'

Which our docs say you should be able to do when using patch API.

https://docs.temporal.io/concepts/what-is-a-search-attribute

Describe the solution you'd like

Add an UpsertSearchAttributes with TemporalChangeVersion: <change_id>-<version_id> with each patch command. Apparently Go SDK does this, but Java doesn't.

SDKs

• Go
• Java Set TemporalChangeVersion when workflow version is updated sdk-java#587
• TS [Feature Request] Upsert TemporalChangeVersion on patch sdk-typescript#817
• Python
• PHP

Additional context

Internal slack link

[rupalivohra]

This also appears to not work for the TS SDK, but I'm guessing solving it in the Core will address that as well?

[lorensr]

Yes.

@Sushisource I was envisioning this done only in Core, but that would mean workflowInfo().searchAttributes wouldn't have TemporalChangeVersion?

[Sushisource]

@lorensr It should be able to have it just fine - maybe not in the same workflow task that you do the upsert, but that's correct in some sense anyway.

[bergundy]

We could add the search attribute when a patch is applied in the TS workflow runtime so it's available when processing the "current" workflow task.

[bergundy]

I think we decided to close this and implement in lang, it's much much simpler