Add warning when the ss_skb_frag_next() fails for precalculated message

vankoven · vankoven · commit 96b8933ed990 · 2019-02-11T22:59:00.000+05:00
diff --git a/tempesta_fw/msg.c b/tempesta_fw/msg.c
@@ -72,8 +72,9 @@ tfw_msg_write(TfwMsgIter *it, const TfwStr *data)
 			skb_frag_t *frag = ss_skb_frag_next(&it->skb,
 							    it->skb_head,
 							    &it->frag);
-			if (unlikely(!frag)
-			    && ((c_size != f_room) || (c + 1 < end)))
+			if (WARN_ON_ONCE(!frag
+					 && ((c_size != f_room)
+					     || (c + 1 < end))))
 			{
 				return -E2BIG;
 			}

Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,9 @@ tfw_msg_write(TfwMsgIter it, const TfwStr data)`
`72`	`72`	`skb_frag_t *frag = ss_skb_frag_next(&it->skb,`
`73`	`73`	`it->skb_head,`
`74`	`74`	`&it->frag);`
`75`		`- if (unlikely(!frag)`
`76`		`- && ((c_size != f_room) \|\| (c + 1 < end)))`
	`75`	`+ if (WARN_ON_ONCE(!frag`
	`76`	`+ && ((c_size != f_room)`
	`77`	`+ \|\| (c + 1 < end))))`
`77`	`78`	`{`
`78`	`79`	`return -E2BIG;`
`79`	`80`	`}`